-
Notifications
You must be signed in to change notification settings - Fork 289
[Klaud Cold] Update qwen3.8next-fp4-b300-sglang-agentic-mtp SGLang image to dev-cu13-qwen38-next-local (2026-09-07, digest-pinned) #2879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
functionstackx
wants to merge
2
commits into
main
Choose a base branch
from
klaud-cold/qwen3.8next-fp4-b300-sglang-agentic-mtp-dev-cu13-qwen38-next-local-20260907
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+11
−2
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 The new entry's pr-link is the literal string "PRLINK_PLACEHOLDER", which is not a value the changelog tooling recognizes: utils/validate_perf_changelog.py's PR_LINK_PLACEHOLDERS only accepts "XXX" or "https://github.com/SemiAnalysisAI/InferenceX/pull/XXX", so validate_added_pr_link raises ChangelogValidationError and the CI gate fails; the merge-prep step (utils/prepare_perf_changelog_merge.py canonicalize_appended_links) also rejects it with "unexpected pr-link" instead of rewriting it to the real PR URL, so this PR cannot pass the changelog gate or be auto-fixed at merge as the repo conventions assume. Fix: use one of the accepted placeholders ("XXX" or the pull/XXX form) for the pr-link field of any newly appended entry.
Extended reasoning...
utils/validate_perf_changelog.py:144-160 validate_added_pr_link(link, pr_number) computes expected = f".../pull/{pr_number}" and raises unless link is in PR_LINK_PLACEHOLDERS ({"XXX", ".../pull/XXX"}) or equals expected. compare_entries (line ~206) calls this for every added entry, and main() is the CI entry point, so any PR run of the gate against this changelog entry (pr-link: PRLINK_PLACEHOLDER) fails validation. Separately, utils/prepare_perf_changelog_merge.py:109-113 canonicalize_appended_links checks
if link not in PR_LINK_PLACEHOLDERS: raise ChangelogValidationError(f"appended entry {index+1} has unexpected pr-link {link!r}"), so the merge-with-reuse tooling that is supposed to rewrite placeholders to the real PR URL also fails on this exact string instead of silently fixing it, contradicting the repo's documented merge flow.Verification: normal. The appended perf-changelog.yaml entry ends with
pr-link: PRLINK_PLACEHOLDER. The recognized set at utils/validate_perf_changelog.py:24-27 is PR_LINK_PLACEHOLDERS = {"XXX", "https://github.com/SemiAnalysisAI/InferenceX/pull/XXX"}; "PRLINK_PLACEHOLDER" is not in it. utils/prepare_perf_changelog_merge.py canonicalize_appended_links (lines ~110-114): link =…