feat(share): redesign share button as popover with consolidated actions#312
Open
functionstackx wants to merge 1 commit intomasterfrom
Open
feat(share): redesign share button as popover with consolidated actions#312functionstackx wants to merge 1 commit intomasterfrom
functionstackx wants to merge 1 commit intomasterfrom
Conversation
Promotes the chart-header share affordance from a small outlined icon-button (easy to miss) to a filled brand-color trigger that opens a popover containing: a one-line explanation, the current share URL auto-selected for Cmd/Ctrl+C, a dedicated Copy button with feedback, and the X / LinkedIn share buttons consolidated inside (previously hidden on mobile behind the sm: breakpoint). Adds share_popover_opened analytics event so popover discoverability can be measured separately from copy / social conversion. Refactors the four direct ShareButton + social-button consumers to use the shared ChartShareActions wrapper. Wires .test.tsx files into vitest's include pattern so the existing chart-display-helpers.test.tsx and the new share-button.test.tsx run in CI (the coverage exclude already listed *.test.tsx, but the include pattern was matching only .test.ts). Closes #268 Co-authored-by: functionstackx <functionstackx@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #268
Summary
Promotes the chart-header share affordance from a small outlined icon-button (easy to miss) to a filled brand-color trigger that opens a popover containing:
sm:breakpoint)Adds a
share_popover_openedanalytics event so popover discoverability can be measured separately from copy / social conversion (share_link_copied,social_share_twitter,social_share_linkedinkept unchanged). Refactors the four directShareButton+ social-button consumers (ThroughputCalculatorDisplay,gpu-specs-content,GpuPowerDisplay,SubmissionsDisplay) to use the sharedChartShareActionswrapper.Also wires
.test.tsxfiles into vitest'sincludepattern so the existingchart-display-helpers.test.tsxand the newshare-button.test.tsxactually run in CI (coverage exclude already listed**/*.test.tsx, butincludewas matching only.test.ts).Test plan
pnpm typecheckpnpm lintpnpm test:unit— 1738/1738 pass (includes newShareButtontests and now-runningchart-display-helperstests)/inference,/calculator,/gpu-specs?unofficialruns=…) — share URL preserves the overlay param, popover opens, copy worksNote on the optional short-link service
Intentionally did not implement the optional
/s/abc123server-side short-link table — that's a DB migration + new API route + URL parser change, a separate concern from "make the button discoverable," and deserves its own design + PR.🤖 Generated with Claude Code