feat(inference): reproduce drawer for benchmark points#310
Open
functionstackx wants to merge 1 commit intomasterfrom
Open
feat(inference): reproduce drawer for benchmark points#310functionstackx wants to merge 1 commit intomasterfrom
functionstackx wants to merge 1 commit intomasterfrom
Conversation
Adds a 3-tab drawer (Command / Config JSON / Environment) that opens from scatter pinned tooltip, GPU graph tooltip, or inference table row, showing exactly how a benchmark was produced. - Pure `buildLaunchCommand(framework, config)` library with per-framework generators for vllm, sglang, trt (with the trtllm alias). Disagg configs emit two stitched commands (prefill / decode workers). Compound stacks (Dynamo, ATOM, MoRI) intentionally show a clear fallback that points at the Config JSON tab. - ReproduceDrawer reuses the existing right-side dialog pattern, with per- tab Copy buttons, a Server log link, and Esc + outside-click close that doesn't perturb chart zoom or URL state. - Drawer state lives in InferenceContext so it is reachable from scatter, GPU graph, and the table without prop-drilling. - Analytics: reproduce_drawer_opened, reproduce_copy (with framework), reproduce_drawer_open_clicked, reproduce_server_log_clicked, inference_table_reproduce_clicked. - Tests: 21 unit tests for buildLaunchCommand cover every framework, disagg, compound fallbacks, alias resolution, missing-field placeholders; 4 new tooltipUtils tests assert the Reproduce button only appears when pinned; new E2E spec exercises the table-row entry point and the unofficial-run overlay path. Closes #270 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Co-authored-by: functionstackx <functionstackx@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a 3-tab drawer (Command / Config JSON / Environment) that opens from a scatter pinned tooltip, GPU graph tooltip, or inference table row and shows exactly how a benchmark was produced.
Implements #270.
Summary
buildLaunchCommand(framework, config)library with per-framework generators forvllm,sglang,trt(and thetrtllmalias), unit-tested.reproduce_drawer_opened,reproduce_copy(withframework),reproduce_server_log_clicked,inference_table_reproduce_clicked.Test plan
pnpm typecheck,pnpm lint,pnpm fmtpnpm test:unit→ 1756/1756 passing (+25 new)?unofficialrun=overlay path🤖 Generated with Claude Code