[Video]: add H3 artifact demo / 新增 H3 产物演示页 - #1086
Conversation
中文:新增 H3 视频产物查看器,直接读取 CI manifest、原始媒体和遥测;复用隐藏导航,区分执行、回归及测量窗口,并提供明确计费口径的收入与利润估算。
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
补齐视频保真度与硬件表格的中文标签,明确假设基准日期、计费口径及缺失数据文案。更新真实参考产物说明;中文移动端与真实媒体播放检查通过。
|
Claude finished @edwingao28's task in 3m 9s —— View job Claude review — H3 video artifact viewer
🟢 LGTM — no blocking issues foundReviewed statically and verified at runtime on the local dev server. What I checked closely and found sound:
Notes (non-blocking):
|
中文:按隐藏生产功能交付 H3 演示,移除新增公开文档。为本地产物服务输出固定的 CORS 来源,验证非法来源与折叠头部不会反射到响应中。
|
Claude finished @edwingao28's task in 2m 27s —— View job Review: PR #1086 — H3 video artifact demo
🟢 LGTM — no blocking issues foundI reviewed the diff statically and verified the pages at runtime. This is a carefully-built, self-contained feature with no inference/backend surface. Runtime verification (localhost, real DB):
CI: typecheck/unit, lint/format, component + full Chrome/Firefox E2E matrix, CodeQL, and Bugbot all pass. Security surface reviewed — looks sound:
Object-URL lifecycle: the Tests: Chinese copy: reviewed the new |
Summary
Add the hidden
/videoand/zh/videoproduction views using the existing ↑↑↓↓ feature flag and InferenceX styling, as requested by Oren. Read the real artifacts from InferenceX #2894 without introducing another backend schema.PR preview uses existing Vercel SSO. After merge the viewer is at
/videoon the production site; collaborators import an authorized downloaded artifact folder.Testing
257a10ce: all eight Chrome/Firefox E2E shards, component tests, full typecheck/unit suite, lint and CodeQL passed. E2E run.中文说明
按 Oren 的要求,使用现有 ↑↑↓↓ 功能开关与 InferenceX 样式,将
/video和/zh/video作为隐藏生产页面交付,直接读取 #2894 的真实产物。本地类型、lint、格式、字体、46 项组件、113 项集成、19 项导航与 103 项定向检查通过;两份真实成功产物和一份失败产物的播放、音频、校验和、下载、错误状态与中文移动端已验证。本地 CORS 来源与折叠头部检查通过。Claude 中文只读审查及复查完成。
257a10ce的 CI 已通过全部八个 Chrome/Firefox E2E 分片、组件测试、完整类型/单元测试、lint 与 CodeQL。合并后查看器位于生产站点
/video;协作者导入有权下载的产物文件夹。生产部署不会自动公开私有媒体。Note
Medium Risk
Introduces client-side fetching from user-supplied manifest URLs and in-browser rendering of untrusted artifact HTML (mitigated by URL rules, checksums, and iframe sandbox/CSP), but the hidden nav is not access control for private bundles.
Overview
Adds a feature-gated H3 video benchmark viewer at
/videoand/zh/video, wired into the existing ↑↑↓↓ unlock and dashboard registry (standalone shell, noindex metadata, Video in the Hidden tab menu).The new
VideoBenchmarkUI loads CI bundles entirely in the browser via extracted artifact folders or a restricted HTTPSmanifest.jsonURL (checksum verification, path hardening, size caps). It surfaces baseline/candidate playback, metrics, power/memory estimates, optional revenue/profit assumptions, and a CSP-sandboxed embedded report—without shipping sample media on an empty page.Supporting changes:
bundle.tsloader/helpers with Vitest contract tests, Cypress navigation/load-error/locale checks, and a loopbackserve-h3-artifact.pyhelper for local CORS demos (localhost-only auto-load from?manifest=).Reviewed by Cursor Bugbot for commit 257a10c. Bugbot is set up for automated code reviews on this repo. Configure here.