Skip to content

refactor: correct order of the latitude and longitude in (*OsrmApiResponse).ToProto() method #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mgiks wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: correct order of the latitude and longitude in (*OsrmApiResponse).ToProto() method #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions services/trip-service/pkg/types/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ func (o *OsrmApiResponse) ToProto() *pb.Route {
coordinates := make([]*pb.Coordinate, len(geometry))
for i, coord := range geometry {
coordinates[i] = &pb.Coordinate{
Latitude: coord[0],
Longitude: coord[1],
Longitude: coord[0],
Latitude: coord[1],
}
}

Expand Down
2 changes: 1 addition & 1 deletion web/src/components/DriverMap.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ export const DriverMap = ({ packageSlug }: { packageSlug: CarPackageSlug }) => {

const parsedRoute = useMemo(() =>
requestedTrip?.route?.geometry[0]?.coordinates
.map((coord) => [coord?.longitude, coord?.latitude] as [number, number])
.map((coord) => [coord?.latitude, coord?.longitude] as [number, number])
, [requestedTrip])

// destination is the last coordinate in the route
Expand Down
4 changes: 2 additions & 2 deletions web/src/components/RiderMap.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export default function RiderMap({ onRouteSelected }: RiderMapProps) {
console.log(data)

const parsedRoute = data.route.geometry[0].coordinates
.map((coord) => [coord.longitude, coord.latitude] as [number, number])
.map((coord) => [coord.latitude, coord.longitude] as [number, number])

setTrip({
tripID: "",
Expand Down Expand Up @@ -237,4 +237,4 @@ export default function RiderMap({ onRouteSelected }: RiderMapProps) {
</div>
</div>
)
}
}