feat: add --rpc-ip to set the public RPC listen address#434
Open
samlaf wants to merge 1 commit into
Open
Conversation
The public RPC listener was hardcoded to 0.0.0.0. Deployments that front it with nginx want it bound to 127.0.0.1 so it isn't reachable off-box; the default stays 0.0.0.0 for direct/local setups and the testnet. Add --rpc-ip (mirrors --prom-ip; default 0.0.0.0), parse it to an IpAddr, and thread it into the public server. The admin RPC stays localhost-only. Consolidate RpcServerBuilder's constructors while here: new()/new_localhost() delegate to a single new_with_listen_addr(), keeping the server hardening (http-only, batch cap, request timeout) in one place rather than duplicated. The in-code RunFlags builders (testnet + e2e bins) set rpc_ip to 0.0.0.0, preserving their current behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public RPC listener was hardcoded to 0.0.0.0. Deployments that front it with nginx want it bound to 127.0.0.1 so it isn't reachable off-box; the default stays 0.0.0.0 for direct/local setups and the testnet. Add --rpc-ip (mirrors --prom-ip; default 0.0.0.0), parse it to an IpAddr, and thread it into the public server. The admin RPC stays localhost-only.
Consolidate RpcServerBuilder's constructors while here: new()/new_localhost() delegate to a single new_with_listen_addr(), keeping the server hardening (http-only, batch cap, request timeout) in one place rather than duplicated.
The in-code RunFlags builders (testnet + e2e bins) set rpc_ip to 0.0.0.0, preserving their current behavior.