feat(deploy_tee): genesis pins eth_genesis_hash from the manifest#53
Merged
Conversation
The ceremony now takes --manifest and pins eth.genesis_hash from it — the value `manifest assemble` computed offline at deploy time — instead of deriving it from whatever the cohort happens to serve. Each node's reth is then asserted to serve that hash as block 0, so a stale image or wrong genesis fails at ceremony time instead of parking summit in SYNCING forever (summit pinning a hash reth doesn't know produces no error on either side). Failure output lists the whole cohort (✓/✗ per node, unreachable nodes included), so one bad node is distinguishable from a manifest that matches nobody, and a down node doesn't hide the rest. -g becomes a dev-only override; the cohort assertion still runs against the overridden value. Also fix --node to accept the repeated-flag form: it was nargs="+" only, so `--node a.json --node b.json` silently replaced a with b and ran the ceremony against a partial cohort — which is how a uniform cohort disagreeing with a stale manifest masqueraded as a single mismatched node during the N=2 bring-up. Both forms now accumulate, duplicates are rejected, and descriptor paths are validated up front.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ceremony now takes --manifest and pins eth.genesis_hash from it — the value
manifest assemblecomputed offline at deploy time — instead of deriving it from whatever the cohort happens to serve. Each node's reth is then asserted to serve that hash as block 0, so a stale image or wrong genesis fails at ceremony time instead of parking summit in SYNCING forever (summit pinning a hash reth doesn't know produces no error on either side). Failure output lists the whole cohort (✓/✗ per node, unreachable nodes included), so one bad node is distinguishable from a manifest that matches nobody, and a down node doesn't hide the rest. -g becomes a dev-only override; the cohort assertion still runs against the overridden value.Also fix --node to accept the repeated-flag form: it was nargs="+" only, so
--node a.json --node b.jsonsilently replaced a with b and ran the ceremony against a partial cohort — which is how a uniform cohort disagreeing with a stale manifest masqueraded as a single mismatched node during the N=2 bring-up. Both forms now accumulate, duplicates are rejected, and descriptor paths are validated up front.