refactor(deploy_tee): shared LUKS poller; tolerate transient wipe errors#51
Merged
Conversation
Extract the render-free polling state machine out of watch_luks_provisioning into poll_provisioning, yielding updates until a terminal one — the single-node watch (seismic-tee status, configure's post-POST wait) and the upcoming parallel cohort dashboard consume the same states. Two behavior changes ride along: - A lone `error` status is no longer terminal. setup-persistent-luks writes `error` per failed attempt and can recover on the next (Restart=on-failure), so the watch only fails on an error that persists ERROR_GRACE_SECONDS with no recovery in between. - An optional stop event ends a poll within one interval, letting a multi-node watcher cancel on ctrl-C instead of waiting out a 1h+ wipe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract the render-free polling state machine out of watch_luks_provisioning into poll_provisioning, yielding updates until a terminal one — the single-node watch (seismic-tee status, configure's post-POST wait) and the upcoming parallel cohort dashboard consume the same states. Two behavior changes ride along:
errorstatus is no longer terminal. setup-persistent-luks writeserrorper failed attempt and can recover on the next (Restart=on-failure), so the watch only fails on an error that persists ERROR_GRACE_SECONDS with no recovery in between.