Repository navigation
fix(runtime): guard CAPTCHA requests and restore checkout regressions - #35
Merged
Seiger merged 3 commits intoOct 28, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CAPTCHA/API entrypoints emit
evolution.OnWebPageInitwithout an HTTP request binding. The marketing listener callsrequest()unconditionally and fails withTarget class [request] does not exist.The branch's existing regression suite also exposed two integration defects: quick checkout performs arithmetic on unvalidated quantities, and cart snapshots omit physical attributes after their column migration.
Changes
physicalPayload()when building cart snapshots, preserving legacy JSON keys and ordering. The existing golden JSON is unchanged; its CRLF/LF handling is portable.Branch and scope
Targets the installed
1.xsupport line, from the MiddleSokilAI fork. No schema, dependency, CMS or production changes.Verification
git diff --checkpasses.e23fe31: https://github.com/Seiger/sCommerce/actions/runs/40706974459. Local PHP 8.5 lacks the PDO SQLite driver, so SQLite suites are not claimed locally verified on that version.Remaining validation
Live CAPTCHA verification on dev is pending installation. Production has not been modified.