Fix stale urdf_path overrides in rebotarm_hardware.yaml - #3
Open
SMEAC wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After
third_party/reBotArm_control_py/urdfwas restructured intourdf/RS/andurdf/DM/subfolders,src/rebotarm_bringup/config/rebotarm_hardware.yamlstill overrodeurdf_pathwith the old, now-nonexistent paths, causing:Fix
Update the
urdf_pathoverrides for both models to match the new layout:rs:urdf/00-arm-rs_asm-v3/urdf/00-arm-rs_asm-v3.urdf->urdf/RS/urdf/ReBot_Arm_RS.urdfdm:urdf/reBot-DevArm_fixend_description/urdf/reBot-DevArm_fixend.urdf->urdf/DM/urdf/ReBot_Arm_DM.urdfThese now match the paths already defined in
third_party/reBotArm_control_py/config/rebotarm_rs.yamlandrebotarm_dm.yaml.(Note: repo issues are disabled, so this PR includes the full bug writeup in place of a separate issue.)
Test
Verified
ros2 launch rebotarm_bringup bringup.launch.py model:=rs channel:=can0no longer fails to find the RS urdf file.