Repository navigation
fix(app-session): support v3 descriptors with Windows regression coverage - #154
Open
Lee-SiHyeon wants to merge 2 commits into
Open
Lee-SiHyeon wants to merge 2 commits into
Lee-SiHyeon wants to merge 2 commits into
Conversation
Current Grok Bot desktop builds write gateway-descriptor.json version 3, which keeps the version 2 entries layout (adds savedAtMs per entry). Every command failed with "Unsupported Grok Bot gateway descriptor version 3". Treat v3 like v2; the multiple-entries safety check stays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F7jcCQRFPBA9cNGeLvEoJi
Exercise the existing Windows DPAPI key-provider path with synthetic v3 fixtures, including invalid entries and AES-GCM authentication failure. Run the built doctor command for v2 and v3 under isolated app-data paths on Windows as well as macOS/Linux, covering the flight worker bundle. Refresh the artifact source snapshot while preserving its executable mode.
🦋 Changeset detectedLatest commit: af40323 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grok Bot Desktop 0.71.2 writes a version 3 gateway descriptor. CLI 0.12.4 rejects that descriptor with
UNSUPPORTED_VERSION, so an already signed-in Windows app cannot provide the CLI's gateway session. Accepting v3 through the existing v2 entries path restores session discovery while retaining single-entry selection and the existing decryption checks.This builds on the open #143: its compatibility fix, Changeset, and generated bundles are cherry-picked from Nicolas Mertens's commit
e9ac66339d422733a6054ff61795d9841ffe43da, preserving his authorship. The additional commit supplies Windows regression coverage and the verified results below. If #143 is the preferred merge vehicle, that test commit can be taken there independently after regenerating the artifact manifest.doctor --jsonagainst isolated v2 and v3 app-data directories on Windows, macOS, and Linux. This exercises the built CLI and its flight worker, catching incomplete bundle updates.Validation on Windows with Node 24.10.0:
0755mode, which the Windows build omits; validating that committed manifest on this host reportsAB6004, also reproduced with the unmodifiedmainartifact. POSIX artifact validation remains for CI.node --test test/app-session.test.js test/doctor.test.js test/url-policy.test.js test/release-config.test.js test/codex-commands.test.js: 40 passed, no failures or skips.npm run test:routes: 97 passed.npm run checkreaches the unit suite but is not fully green on this Windows host: 170 passed, 3 failed, 28 skipped. All three failures also reproduce in a separately built, unmodifiedmaincheckout at43499fa: the history disk-failure assertion, Windows absolute-path ESM import inhost-tool-inventory.test.js, and symlink privilegeEPERMinrelay-state.test.js.