chore(trends): cover weekday bucket alignment - #34
Open
lordspline wants to merge 1 commit into
Open
Conversation
🦔 Hogbox preview · ❌ build failedThe preview didn't come up for commit Previews are optional and never block merging. A failure here is often a hogland or tailnet hiccup rather than anything in your PR, so the check stays green and this comment is the status. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Trends contributors lacked regression coverage proving weekday exclusions preserve populated days after the most recent weekend.
PostHog#61782 no longer reproduces because
hideWeekendsis ignored anddateRange.daysOfWeekowns weekday filtering.Changes
hideWeekendsfield produces the same response when disabled or enabled.3, 3, 3, 12.No product UI changes. The Storybook stories provide deterministic visual fixtures for the response shapes.
How did you test this code?
hogli ci:preflight --fixwith no failures.Automatic notifications
Docs update
None. This PR adds regression evidence without changing user-facing behavior.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Capy traced the historical issue and current query-to-chart path before editing. The investigation found the production fix and later retirement already landed, so this PR adds evidence instead of another behavior patch.
Skills invoked:
/writing-ui-components,/writing-tests,/writing-user-facing-copy,/qa-frontend,/setting-feature-flags-in-storybook,/running-ci-preflight, and/writing-pr-descriptions.All committed fixture data is invented and contains no customer material.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.