docs: fix sprint epoch endpoint#5218
Conversation
haocyan0723-code
left a comment
There was a problem hiding this comment.
I checked the two endpoint examples against the live site.
Good catch on the stale path: https://rustchain.org/api/epoch returns 404, while https://rustchain.org/epoch returns 200 with epoch data, so the first replacement is correct.
One thing still needs attention in the second example, though: the live /epoch response I get does not include total_weight. It currently returns fields like blocks_per_epoch, enrolled_miners, epoch, epoch_pot, slot, and total_supply_rtc, so this command still prints null:
curl -sk https://rustchain.org/epoch | jq .total_weightThat means the endpoint path is fixed, but the “Check total network weight” snippet is still not usable as written. Either the docs need the current field/API that exposes network weight, or that example should be rewritten to match what /epoch actually returns.
I would keep the first change and adjust the second snippet before merging.
PR Review — Standard Quality ✓PR: #5218 — Docs: fix sprint epoch endpoint What I reviewed
Observations
LGTM. Bounty: #2782 |
|
Welcome to RustChain! Thanks for your first pull request. Before we review, please make sure:
Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150) A maintainer will review your PR soon. Thanks for contributing! |
HCIE2054
left a comment
There was a problem hiding this comment.
LGTM! Thanks for contributing!
Summary
Verification
Bounty: #2178