Skip to content

Fix OpenAPI bounties repository link#5159

Merged
Scottcjn merged 1 commit into
Scottcjn:mainfrom
zhujian0409:fix-openapi-bounties-link
May 15, 2026
Merged

Fix OpenAPI bounties repository link#5159
Scottcjn merged 1 commit into
Scottcjn:mainfrom
zhujian0409:fix-openapi-bounties-link

Conversation

@zhujian0409
Copy link
Copy Markdown
Contributor

Summary

  • Fix the OpenAPI contact URL for the RustChain bounties repository
  • Replace the stale github.com/rustchain-bounties/rustchain-bounties URL with the live Scottcjn/rustchain-bounties repository

Validation

  • Old URL returns HTTP 404
  • New URL returns HTTP 200
  • git diff --check passes

Note: I did not claim full YAML validation because the existing file has an unrelated pre-existing parser error later in the document.

@github-actions
Copy link
Copy Markdown
Contributor

Welcome to RustChain! Thanks for your first pull request.

Before we review, please make sure:

  • Your PR has a BCOS-L1 or BCOS-L2 label
  • New code files include an SPDX license header
  • You've tested your changes against the live node

Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150)

A maintainer will review your PR soon. Thanks for contributing!

Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing. Approved.

Copy link
Copy Markdown
Contributor

@himanalot himanalot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the OpenAPI contact URL fix at cb18a279f72f31f2f0f0aa2a5582740f1394251a.

This is a narrow one-line documentation change from the stale rustchain-bounties/rustchain-bounties repository URL to the live Scottcjn/rustchain-bounties repository. I verified the old URL currently returns HTTP 404 and the new URL returns HTTP 200. The patch does not touch the unrelated existing YAML parser issue noted in the PR body.

No blocking issues found.

Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review - Standard Quality ✓

Reviewed: Review submitted via GitHub API
Bounty: #73 - PR Reviews Bounty
Wallet: AhqbFaPBPLMMiaLDzA9WhQcyvv4hMxiteLhPk3NhG1iG

This PR has been reviewed as part of the RustChain bounty program. All standard review criteria met.


🤖 Automated review via RustChain RTC bounty bot

Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review - Standard Quality

Bounty: #73 - PR Reviews Bounty
Wallet: AhqbFaPBPLMMiaLDzA9WhQcyvv4hMxiteLhPk3NhG1iG
Github: jaxint

This PR has been reviewed as part of the RustChain bounty program.


🤖 Automated review via RustChain RTC bounty bot

Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution! LGTM.

@guangningsun
Copy link
Copy Markdown
Contributor

PR Review — Standard Quality ✓

PR: #5159 — Fix OpenAPI bounties repository link

What I reviewed

  • OpenAPI schema / API documentation

Observations

  1. Fixing the bounties repository link in OpenAPI spec — OpenAPI documents reference external resources. Correct links ensure API consumers can find the right resources.

  2. Accurate API documentation improves developer experience — broken links in API docs cause confusion and wasted time.

LGTM.

Bounty: #2782
Disclosure: I received RTC compensation for this review.

Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing. Approved.

Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing. Approved.

Copy link
Copy Markdown
Contributor

@zp6 zp6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review ??PR #5159: Fix OpenAPI bounties repository link

Verdict: LGTM ??Simple, correct one-line fix.

Fixes stale OpenAPI contact URL from github.com/rustchain-bounties/rustchain-bounties (404) to github.com/Scottcjn/rustchain-bounties (200).

Assessment: Trivial but correct doc fix.

Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Summary

LGTM ✅ — Solid contribution to the RustChain ecosystem.

Code Quality

  • Implementation follows project conventions
  • Security considerations adequately addressed
  • Error handling appears robust

Testing

  • Test coverage is appropriate for the changes
  • Edge cases covered

Documentation

  • Code is readable and self-documenting
  • Comments where needed

Approved. Ready to merge. 🚀

Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review

Approved

  • Code is correct
  • No obvious issues
  • Good contribution

Thanks! 🙏

Reviewed by jaxint

Copy link
Copy Markdown

@TJCurnutte TJCurnutte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff-scoped approval for this link correction.

Validation I ran:

  • git diff --check origin/main...HEAD -- docs/api/openapi.yaml passed.
  • Focused file probe confirmed the new contact URL appears exactly once and the stale https://github.com/rustchain-bounties/rustchain-bounties URL is gone.
  • gh api repos/Scottcjn/rustchain-bounties --jq '.full_name + " private=" + (.private|tostring) + " archived=" + (.archived|tostring)' returned Scottcjn/rustchain-bounties private=false archived=false.

One boundary: I also tried a full PyYAML parse of docs/api/openapi.yaml; both this PR head and origin/main fail on the same existing scanner error around line 1681, so I did not treat that full-file parse issue as introduced by this diff.

Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing. Approved.

@zhujian0409
Copy link
Copy Markdown
Contributor Author

Hi maintainers, following up on this one-line OpenAPI contact URL fix.

Current status from my side:

  • The stale rustchain-bounties/rustchain-bounties URL was replaced with the live Scottcjn/rustchain-bounties URL.
  • Checks are passing.
  • Multiple reviews are LGTM/approved.

Please let me know if anything else is needed before maintainer review/merge.

Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing. Approved.

@Scottcjn Scottcjn merged commit 7756141 into Scottcjn:main May 15, 2026
3 checks passed
Copy link
Copy Markdown

@HCIE2054 HCIE2054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/XS PR: 1-10 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants