Repository navigation
goneovim-nightly: update checkver - #17
Conversation
Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. goneovim-nightly
|
|
/verify |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
bucket/g/goneovim-nightly.json (1)
28-33:⚠️ Potential issue | 🔴 CriticalBroken checkver:
githubfield expects a repository URL, not an API URL — will create malformed/releases/latestendpoint.Scoop's
checkver.githubfield is designed to accept a repository URL (e.g.,https://github.com/akiyosi/goneovim), not an API endpoint. The checkver script appends/releases/latestto whatever value is provided:if ($json.checkver.github) { $url = $json.checkver.github.TrimEnd('/') + '/releases/latest'With the PR's value, this produces:
https://api.github.com/repos/akiyosi/goneovim/releases/tags/nightly/releases/latestThis endpoint does not exist and checkver will fail. All other manifests in the Scoop bucket correctly use the repository URL format (e.g.,
https://github.com/updatecli/updatecli,https://github.com/github/hub); goneovim-nightly is the only exception.Additionally, even if using a valid repo URL with the
githubshorthand,/releases/latestreturns the latest stable release, not the nightly tag. The original approach using theurlfield to directly specify the tags/nightly endpoint is the correct pattern for tracking a specific release tag.Switch
githubtourl:Proposed fix
"checkver": { - "github": "https://api.github.com/repos/akiyosi/goneovim/releases/tags/nightly", + "url": "https://api.github.com/repos/akiyosi/goneovim/releases/tags/nightly", "jsonpath": "$.assets[?(@.name =~ /goneovim-windows-(x86_64|arm64).zip/)].updated_at", "regex": ".*(?<year>\\d{4})\\D(?<month>\\d{2})\\D(?<day>\\d{2}).*", "replace": "${year}${month}${day}" },🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@bucket/g/goneovim-nightly.json` around lines 28 - 33, The checkver block is using the API endpoint in the checkver.github field which causes checkver to append /releases/latest and produce a bad URL; replace the "github" key with a "url" key that points directly to the tags/nightly release endpoint (e.g., the API or tags URL you intended) and keep the existing jsonpath, regex and replace values intact so checkver parses the asset updated_at correctly; update the checkver object (the keys named "github", "jsonpath", "regex", "replace") to use "url" instead of "github" and ensure the URL you provide points to the specific nightly tag endpoint rather than a repo homepage.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@bucket/g/goneovim-nightly.json`:
- Around line 28-33: The checkver block is using the API endpoint in the
checkver.github field which causes checkver to append /releases/latest and
produce a bad URL; replace the "github" key with a "url" key that points
directly to the tags/nightly release endpoint (e.g., the API or tags URL you
intended) and keep the existing jsonpath, regex and replace values intact so
checkver parses the asset updated_at correctly; update the checkver object (the
keys named "github", "jsonpath", "regex", "replace") to use "url" instead of
"github" and ensure the URL you provide points to the specific nightly tag
endpoint rather than a repo homepage.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 43bc3702-5b74-4ebe-ba9e-5c5967fddb74
📒 Files selected for processing (1)
bucket/g/goneovim-nightly.json
|
All changes look good. Wait for review from human collaborators. goneovim-nightly
|
test workflow permissions
Closes #XXXX
Relates to #XXXX
Summary by CodeRabbit