Skip to content

goneovim-nightly: update checkver - #17

Merged
chawyehsu merged 1 commit into
masterfrom
push-xurzpwoywlnr
Apr 24, 2026
Merged

chawyehsu merged 1 commit into
masterfrom
push-xurzpwoywlnr

Conversation

@chawyehsu

@chawyehsu chawyehsu commented Apr 24, 2026 •

Copy link
Copy Markdown
Member

test workflow permissions

Closes #XXXX

Relates to #XXXX

Summary by CodeRabbit

  • Chores
    • Updated nightly build auto-update configuration mechanism.

Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
@chawyehsu chawyehsu self-assigned this Apr 24, 2026
@coderabbitai

coderabbitai Bot commented Apr 24, 2026 •

Copy link
Copy Markdown

Walkthrough

The checkver metadata in a nightly auto-update manifest has been updated to use a GitHub API endpoint instead of a URL endpoint, targeting the akiyosi/goneovim repository's nightly tag. The version extraction logic remains unchanged.

Changes

Cohort / File(s) Summary
Nightly Build Configuration
bucket/g/goneovim-nightly.json
Updated checkver endpoint from URL-based to GitHub API endpoint for the nightly tag version detection.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A single line hops to GitHub's API,
Where nightly versions dance and play,
Version checks now swift and true,
Configuration fresh, and manifest anew! 🌙✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description lacks required issue references and fails to explain the actual changes made to the goneovim-nightly package. Add a reference to the issue being closed or related (Closes #XXXX or Relates to #XXXX) and provide a clear explanation of why the checkver metadata was updated from a URL endpoint to a GitHub API endpoint.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: updating the checkver configuration for the goneovim-nightly package, which matches the actual modification in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch push-xurzpwoywlnr

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

goneovim-nightly

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@chawyehsu

Copy link
Copy Markdown
Member Author

/verify

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
bucket/g/goneovim-nightly.json (1)

28-33: ⚠️ Potential issue | 🔴 Critical

Broken checkver: github field expects a repository URL, not an API URL — will create malformed /releases/latest endpoint.

Scoop's checkver.github field is designed to accept a repository URL (e.g., https://github.com/akiyosi/goneovim), not an API endpoint. The checkver script appends /releases/latest to whatever value is provided:

if ($json.checkver.github) {
    $url = $json.checkver.github.TrimEnd('/') + '/releases/latest'

With the PR's value, this produces:

https://api.github.com/repos/akiyosi/goneovim/releases/tags/nightly/releases/latest

This endpoint does not exist and checkver will fail. All other manifests in the Scoop bucket correctly use the repository URL format (e.g., https://github.com/updatecli/updatecli, https://github.com/github/hub); goneovim-nightly is the only exception.

Additionally, even if using a valid repo URL with the github shorthand, /releases/latest returns the latest stable release, not the nightly tag. The original approach using the url field to directly specify the tags/nightly endpoint is the correct pattern for tracking a specific release tag.

Switch github to url:

Proposed fix
     "checkver": {
-        "github": "https://api.github.com/repos/akiyosi/goneovim/releases/tags/nightly",
+        "url": "https://api.github.com/repos/akiyosi/goneovim/releases/tags/nightly",
         "jsonpath": "$.assets[?(@.name =~ /goneovim-windows-(x86_64|arm64).zip/)].updated_at",
         "regex": ".*(?<year>\\d{4})\\D(?<month>\\d{2})\\D(?<day>\\d{2}).*",
         "replace": "${year}${month}${day}"
     },
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@bucket/g/goneovim-nightly.json` around lines 28 - 33, The checkver block is
using the API endpoint in the checkver.github field which causes checkver to
append /releases/latest and produce a bad URL; replace the "github" key with a
"url" key that points directly to the tags/nightly release endpoint (e.g., the
API or tags URL you intended) and keep the existing jsonpath, regex and replace
values intact so checkver parses the asset updated_at correctly; update the
checkver object (the keys named "github", "jsonpath", "regex", "replace") to use
"url" instead of "github" and ensure the URL you provide points to the specific
nightly tag endpoint rather than a repo homepage.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@bucket/g/goneovim-nightly.json`:
- Around line 28-33: The checkver block is using the API endpoint in the
checkver.github field which causes checkver to append /releases/latest and
produce a bad URL; replace the "github" key with a "url" key that points
directly to the tags/nightly release endpoint (e.g., the API or tags URL you
intended) and keep the existing jsonpath, regex and replace values intact so
checkver parses the asset updated_at correctly; update the checkver object (the
keys named "github", "jsonpath", "regex", "replace") to use "url" instead of
"github" and ensure the URL you provide points to the specific nightly tag
endpoint rather than a repo homepage.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 43bc3702-5b74-4ebe-ba9e-5c5967fddb74

📥 Commits

Reviewing files that changed from the base of the PR and between 667b28b and fe82168.

📒 Files selected for processing (1)
  • bucket/g/goneovim-nightly.json

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

goneovim-nightly

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@chawyehsu
chawyehsu merged commit 48be0e4 into master Apr 24, 2026
4 checks passed
@chawyehsu
chawyehsu deleted the push-xurzpwoywlnr branch April 24, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant