Repository navigation
pulumi@3.272.0: Remove unbundled Java runtime from bin - #8777
Conversation
|
/verify |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Remove obsolete Java shim entry bucket/pulumi.json |
The manifest no longer lists pulumi-language-java.exe in its bin list. |
Priority:
Severity of issue fixed: Medium
Merge Risk: 
Minimal · up to 858f4
-
No actionable issue remains with this manifest correction; it is ready for normal merge checks.
Pre-merge checks: 
4
-
Full details: Description check
-
Explanation
The description explains why the change is needed: Pulumi no longer bundles pulumi-language-java.exe after upstream PR 25205, and Scoop's shim attempt fails with "Can't shim 'pulumi-language-java.exe': File doesn't exist." It links the issue (Closes
#8776), describes the one-line fix, and lists validation steps on Windows x64 with Pulumi 3.272.0. It also includes the template's conventional-title and contributing-guide checkboxes, both checked. The template's comment block asks for an issue link in the form Closes#XXXXor Relates to#XXXX, and the author used Closes#8776, so that requirement is met. The description is complete and matches the template's required information.
Full details: Linked Issues check
-
Explanation
Issue
#8776is the only directly linked issue. Its coding requirement is to remove onlypulumi-language-java.exefrom the Pulumibinlist so that update and fresh install finish. The whole-PR diff against the merge base (ed8a684) removes exactly that entry frombucket/pulumi.json(@@ -18,7 +18,6 @@). At head 858f480, thebinarray contains 10 entries and no Java entry. Theversion,architectureURLs and hashes,extract_dir,checkver, andautoupdatesettings are unchanged. The issue has no automated test requirement, and the repository contains no test change in this PR. The archive contents (Java absent, remaining targets present) are author-reported validation. This assessment did not inspect the ZIP, so that claim rests on the PR description and the issue text.
Full details: Out of Scope Changes check
-
Explanation
The whole-PR diff contains one removed line in
bucket/pulumi.json: thepulumi-language-java.exeentry inbin. This change is the objective of#8776. No other files or hunks changed. No out-of-scope change was found.
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
All changes look good. Wait for review from human collaborators. pulumi
|
Pulumi no longer bundles
pulumi-language-java.exeafter pulumi/pulumi#25205; the CLI downloads the Java runtime on demand. Scoop still tries to shim that executable, causing installation and updates to stop withCan't shim 'pulumi-language-java.exe': File doesn't exist.Remove the obsolete Java entry from
binso installation can finish.Closes #8776.
Validation on Windows x64 with Pulumi 3.272.0:
Verified the cached ZIP's SHA512 against the manifest and confirmed Java is absent.
Parsed the corrected JSON and confirmed every remaining
bintarget exists.Repaired the interrupted local installation and successfully rebuilt all listed shims with
scoop reset pulumi.pulumi versionreportsv3.272.0;scoop update pulumicompletes without errors.git diff --checkpasses. Download URLs, hashes and autoupdate settings are unchanged.Use conventional PR title:
<manifest-name[@version]|chore>: <general summary of the pull request>I have read the Contributing Guide