[xeexee98]

What does this PR do?

Removes the now-invalid extract_dir from photocraft@0.18.0 for all three Windows architectures (64bit / 32bit / arm64), and from the corresponding autoupdate blocks.

Why

Starting with 0.18.0 the upstream portable ZIPs no longer contain a top-level wrapper directory. Every previous release shipped files under photocraft-<version>-windows-<arch>-portable/; 0.18.0 puts all 21 entries at the archive root (photocraft.exe, photocraft-cli.exe, ATTRIBUTION.md, NOTICE, …).

Verified against the published assets by reading each archive's central directory (Content-Length + Range request, no full download):

asset	top-level entries	wrapper dir
photocraft-0.18.0-windows-x64-portable.zip	21	none
photocraft-0.18.0-windows-x86-portable.zip	21	none
photocraft-0.18.0-windows-arm64-portable.zip	21	none

extract_dir is also dropped from autoupdate, otherwise the next autoupdate run regenerates the same broken block.

What currently happens without this fix

scoop install photocraft / scoop update photocraft fails:

Loading photocraft-0.18.0-windows-x64-portable.zip from cache.
Checking hash of photocraft-0.18.0-windows-x64-portable.zip... OK.
Uninstalling 'photocraft' (0.17.0)
Installing 'photocraft' (0.18.0) [64bit] from 'extras' bucket
Extracting photocraft-0.18.0-windows-x64-portable.zip... Exception: ...\lib\core.ps1:881
  throw "Could not find '$(fname $from)'! (error $($proc.ExitCode))"
Could not find 'photocraft-0.18.0-windows-x64-portable'! (error 16)

The chain:

1. extract_dir is passed to 7-Zip as an entry filter; the archive has no such entry, so 7-Zip matches 0 files and still exits 0 (No files to process / Everything is Ok / Files: 0 in 7zip.log).
2. scoop then runs movedir on the non-existent apps\photocraft\0.18.0\photocraft-0.18.0-windows-x64-portable.
3. robocopy returns exit code 16 (serious error, nothing copied), which movedir converts into the throw above.

Note the failure ordering: the previous version is already uninstalled by then, so the app ends up uninstalled with no current junction — a failed update leaves the user with nothing.

Testing

• bin (photocraft-cli.exe) and shortcuts (photocraft.exe) resolve at the extraction root, which matches the new layout
• persist (PhotoCraftData) is unaffected
• Hashes, URLs and checkver left untouched

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: ScoopInstaller/Extras
• Branch: master
• File: .coderabbit.yaml
• Commit: 4aff13c
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 80387fdb-22d3-4691-b15e-57ed1ab0a034

Commits

Reviewing files that changed from the base of the PR and between 4aff13c and 2ec93b1.

Files selected for processing: 1

• bucket/photocraft.json

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Walkthrough

The PhotoCraft manifest removes extract_dir settings from the 64-bit, 32-bit, and ARM64 architecture definitions and autoupdate templates. Download URLs and hashes remain unchanged.

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Bug fix

Merge Risk: Minimal · up to 2ec93

No actionable merge-blocking risk is identified for this manifest-only change.

Pre-merge checks: 4

Check name	Status	Explanation
Description check		The description is complete and relevant. It explains the change, cause, failure behavior, affected architectures, validation steps, and unchanged fields. It does not include the template's explicit c…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Title check		The title clearly identifies the affected package and version and states the main change: removing extract_dir.

Full details: Description check

Explanation

The description is complete and relevant. It explains the change, cause, failure behavior, affected architectures, validation steps, and unchanged fields. It does not include the template's explicit checklist or issue reference, but these omissions do not prevent review.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[z-Fng]

/verify

[github-actions]

All changes look good.

Wait for review from human collaborators.

photocraft

• Lint
• Description
• License
• Hashes
• Checkver
• Autoupdate
• Autoupdate Hash Extraction

Check the full log for details.