Skip to content

Fix DiscreteMeasures IntervalArithmetic 1.x clamp_domain (downgrade floor) #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 2 commits into from
Oct 3, 2026
Merged

Fix DiscreteMeasures IntervalArithmetic 1.x clamp_domain (downgrade floor) #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9251200
Fix DiscreteMeasures IntervalArithmetic 1.x clamp_domain API
ChrisRackauckas Sep 26, 2026
7bcb7d1
Make IntervalArithmeticExt imports explicit for ExplicitImports QA
ChrisRackauckas Sep 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/DiscreteMeasures/ext/IntervalArithmeticExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
module IntervalArithmeticExt

using DiscreteMeasures, IntervalArithmetic
using DiscreteMeasures: DiscreteMeasures, clamp_domain
using IntervalArithmetic: IntervalArithmetic, Interval, interval, intersect_interval

println("Load Ext")
function DiscreteMeasures.clamp_domain(x::Interval, lb, ub)
bounds = interval(lb, ub)
return intersect(x, bounds)
return intersect_interval(x, bounds)
end

function DiscreteMeasures.clamp_weight(w::Interval{T}, maxw::T = one(T)) where {T}
Expand Down
12 changes: 7 additions & 5 deletions lib/DiscreteMeasures/test/Core/discrete_measures_tests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,13 @@ end
end

@testset "Interval Ext" begin
@test clamp_domain(interval(-2, -1), 0, 2) == emptyinterval()
@test clamp_domain(interval(-2, 1), 0, 2) == interval(0, 1)
@test clamp_domain(interval(0.1, 0.5), 0, 2) == interval(0.1, 0.5)
@test clamp_domain(interval(0.5, 5), 0, 2) == interval(0.5, 2)
@test clamp_domain(interval(3, 4), 0, 2) == emptyinterval()
# IntervalArithmetic 1.x: use isequal_interval — `==` on non-thin
# decorated intervals throws InconclusiveBooleanOperation.
@test isequal_interval(clamp_domain(interval(-2, -1), 0, 2), emptyinterval())
@test isequal_interval(clamp_domain(interval(-2, 1), 0, 2), interval(0, 1))
@test isequal_interval(clamp_domain(interval(0.1, 0.5), 0, 2), interval(0.1, 0.5))
@test isequal_interval(clamp_domain(interval(0.5, 5), 0, 2), interval(0.5, 2))
@test isequal_interval(clamp_domain(interval(3, 4), 0, 2), emptyinterval())
end

end
Loading