Skip to content

1543 harmonize description of time series infection states etc in documentation#1545

Merged
kilianvolmer merged 16 commits intomainfrom
1543-harmonize-description-of-time-series-infection-states-etc-in-documentation
Apr 23, 2026
Merged

1543 harmonize description of time series infection states etc in documentation#1545
kilianvolmer merged 16 commits intomainfrom
1543-harmonize-description-of-time-series-infection-states-etc-in-documentation

Conversation

@jubicker
Copy link
Copy Markdown
Member

@jubicker jubicker commented Apr 21, 2026

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Use `` in the documentation when refered to classes
  • replace mio::TimeSeries just by TimeSeries

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below).
  • New code adheres to coding guidelines.
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.).
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP).
  • Appropriate documentation within the code (Doxygen) for new functionality has been added in the code.
  • Appropriate external documentation (ReadTheDocs) for new functionality has been added to the online documentation and checked in the preview.
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added.
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed.
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.).
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease).
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.).
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

closes #1543

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.40%. Comparing base (c83172c) to head (fb0ddb0).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1545   +/-   ##
=======================================
  Coverage   97.40%   97.40%           
=======================================
  Files         190      190           
  Lines       16858    16866    +8     
=======================================
+ Hits        16420    16428    +8     
  Misses        438      438           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jubicker jubicker requested a review from kilianvolmer April 21, 2026 09:59
Copy link
Copy Markdown
Contributor

@kilianvolmer kilianvolmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making all these changes! I found only a few things you overlooked. However, I suggest removing all the mentions of mio from TimeSeries as they were used very inconsistently.
Finally, I would actually prefer to use TimeSeries instead of :code:TimeSeries, for consistency and easy reading of the rst files. What do you think of that?

Comment thread docs/source/cpp/models/osecirvvs.rst Outdated
Comment thread docs/source/cpp/models/osecirvvs.rst Outdated
Comment thread docs/source/cpp/models/oseir.rst Outdated
Comment thread docs/source/cpp/models/oseir.rst Outdated
Comment thread docs/source/cpp/models/oseirdb.rst Outdated
Comment thread docs/source/cpp/sbml.rst Outdated
Comment thread docs/source/cpp/models/osecirts.rst Outdated
Comment thread docs/source/cpp/models/osecir.rst Outdated
Comment thread docs/source/cpp/models/lsecir2d.rst Outdated
Comment thread docs/source/cpp/models/lsecir.rst Outdated
@jubicker
Copy link
Copy Markdown
Member Author

Thank you! Removing mio:: from TimeSeries and using TimeSeries instead of the :code: version sounds good. I'll do that and rerequest your review once done :)

Co-authored-by: Kilian Volmer <13285635+kilianvolmer@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@kilianvolmer kilianvolmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a couple more mentions to change.

Comment thread docs/source/cpp/models/glsecir.rst Outdated
Comment thread docs/source/cpp/models/iseir.rst Outdated
Comment thread docs/source/cpp/models/lsecir.rst Outdated
Comment thread docs/source/cpp/models/lsecir.rst Outdated
Comment thread docs/source/cpp/models/lsecir2d.rst Outdated
Comment thread docs/source/cpp/models/osecirts.rst Outdated
Comment thread docs/source/cpp/models/osecirvvs.rst Outdated
Comment thread docs/source/cpp/models/isecir.rst Outdated
Comment thread docs/source/cpp/models/isecir.rst Outdated
Comment thread docs/source/cpp/models/glsecir.rst Outdated
jubicker and others added 4 commits April 21, 2026 15:57
Co-authored-by: Kilian Volmer <13285635+kilianvolmer@users.noreply.github.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR harmonizes documentation terminology and formatting around core modeling concepts (e.g., time series, infection states, model types) to consistently distinguish code objects from general prose, addressing #1543.

Changes:

  • Replace bold/normal-text code-object references with inline code formatting (... / :code:...).
  • Standardize references to TimeSeries by dropping mio:: in narrative text.
  • Apply the same formatting harmonization across multiple Python and C++ documentation pages.

Reviewed changes

Copilot reviewed 31 out of 31 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
docs/source/python/m-simulation_model_usage.rst Use inline code formatting for DynamicNPIs, TimeSeries, FlowModel in Python tutorial text.
docs/source/python/m-simulation_expanding_bindings.rst Format TimeSeries as inline code in bindings tutorial.
docs/source/getting_started.rst Format infection state / flow model references as inline code in getting started overview.
docs/source/cpp/temporal_hybrid.rst Replace narrative mio::TimeSeries references with TimeSeries inline code.
docs/source/cpp/smm.rst Replace bold code-object references with inline code formatting (e.g., Influence, Simulation, TimeSeries).
docs/source/cpp/sde.rst Replace bold code-object references with inline code formatting (StochasticModel, CompartmentalModel, etc.).
docs/source/cpp/sbml.rst Format Populations as inline code in SBML limitations text.
docs/source/cpp/performance_monitoring.rst Consistently format timing framework class names (AutoTimer, BasicTimer, etc.) as inline code.
docs/source/cpp/ode_creation.rst Format CompartmentalModel, FlowModel, Parameters, mio::AgeGroup references consistently.
docs/source/cpp/ode.rst Replace bold code-object references with inline code formatting across ODE overview.
docs/source/cpp/models/osir.rst Harmonize code-object formatting (InfectionState, CompartmentalModel, AgeGroup, Populations).
docs/source/cpp/models/oseirv.rst Harmonize code-object formatting (InfectionState, FlowModel, AgeGroup, Populations, TimeSeries).
docs/source/cpp/models/oseirdb.rst Harmonize code-object formatting (InfectionState, FlowModel, AgeGroup, Populations, TimeSeries).
docs/source/cpp/models/oseir.rst Harmonize code-object formatting (InfectionState, FlowModel, AgeGroup, Populations, TimeSeries).
docs/source/cpp/models/osecirvvs.rst Harmonize code-object formatting (InfectionState, FlowModel, Simulation, TimeSeries).
docs/source/cpp/models/osecirts.rst Harmonize code-object formatting (InfectionState, FlowModel, AgeGroup, Populations, TimeSeries).
docs/source/cpp/models/osecir.rst Harmonize code-object formatting (InfectionState, FlowModel, AgeGroup, Populations, DynamicNPIs, TimeSeries).
docs/source/cpp/models/omseirs4.rst Harmonize code-object formatting (InfectionState, CompartmentalModel, TimeSeries).
docs/source/cpp/models/lsecir2d.rst Replace narrative mio::TimeSeries mentions with TimeSeries and avoid code-styling generic “infection states”.
docs/source/cpp/models/lsecir.rst Replace narrative mio::TimeSeries mentions with TimeSeries and avoid code-styling generic “infection states”.
docs/source/cpp/models/iseir.rst Use inline code formatting for TimeSeries and InfectionState.
docs/source/cpp/models/isecir.rst Use inline code formatting for InfectionState, Simulation, TimeSeries, InfectionTransition.
docs/source/cpp/models/glsecir.rst Replace narrative mio::TimeSeries mentions with TimeSeries and avoid code-styling generic “infection states”.
docs/source/cpp/mobility_based_abm.rst Format TimeSeries as inline code in ABM history description.
docs/source/cpp/lct_creation.rst Format Parameters, mio::ParameterSet, CompartmentalModel, TimeSeries references as inline code.
docs/source/cpp/lct.rst Harmonize code-object formatting (InfectionState, LctInfectionState, CompartmentalModel, TimeSeries, etc.).
docs/source/cpp/io.rst Replace narrative mio::TimeSeries mentions with TimeSeries and format IO framework concept names as inline code.
docs/source/cpp/ide.rst Harmonize code-object formatting and adjust where “time series” is used as a general concept vs code object.
docs/source/cpp/glct.rst Harmonize code-object formatting for GLCT docs (InfectionState, LctInfectionState, etc.).
docs/source/cpp/diffusive_abm.rst Harmonize code-object formatting (QuadWell, SingleWell, Influence, Simulation, TimeSeries).
docs/source/cpp/data_types.rst Switch selected data type names (e.g., TimeSeries, ContactMatrix) to inline code formatting in the table.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/source/python/m-simulation_model_usage.rst Outdated
Comment thread docs/source/cpp/models/osecirts.rst Outdated
Comment thread docs/source/cpp/models/iseir.rst Outdated
Comment thread docs/source/cpp/lct_creation.rst Outdated
Comment thread docs/source/python/m-simulation_model_usage.rst Outdated
Comment thread docs/source/cpp/io.rst Outdated
Comment thread docs/source/cpp/models/lsecir2d.rst Outdated
Comment thread docs/source/cpp/models/lsecir.rst Outdated
Comment thread docs/source/getting_started.rst Outdated
jubicker and others added 2 commits April 23, 2026 09:16
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@kilianvolmer kilianvolmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for changing all the inline code blocks! I found a few more things we should change but I hope then we have everything.

Comment thread docs/source/cpp/lct_creation.rst Outdated
Comment thread docs/source/cpp/lct_creation.rst Outdated
Comment thread docs/source/cpp/lct_creation.rst Outdated
Comment thread docs/source/cpp/ode.rst Outdated
Comment thread docs/source/cpp/ode_creation.rst Outdated
Comment thread docs/source/cpp/performance_monitoring.rst Outdated
Comment thread docs/source/cpp/performance_monitoring.rst Outdated
Comment thread docs/source/python/m-simulation_model_usage.rst Outdated
Comment thread docs/source/python/m-simulation_model_usage.rst Outdated
Comment thread docs/source/python/m-simulation_model_usage.rst Outdated
jubicker and others added 3 commits April 23, 2026 11:14
Co-authored-by: Kilian Volmer <13285635+kilianvolmer@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@kilianvolmer kilianvolmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I fixed the last problems, we are ready to merge! 🥳

Copy link
Copy Markdown
Member Author

@jubicker jubicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good :)

@kilianvolmer kilianvolmer merged commit b63e7be into main Apr 23, 2026
1 check was pending
@kilianvolmer kilianvolmer deleted the 1543-harmonize-description-of-time-series-infection-states-etc-in-documentation branch April 23, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Harmonize description of time series, infection states etc in documentation

3 participants