Skip to content

Add gmgpolar namespace#215

Merged
EmilyBourne merged 2 commits intomainfrom
ebourne_namespace
Apr 21, 2026
Merged

Add gmgpolar namespace#215
EmilyBourne merged 2 commits intomainfrom
ebourne_namespace

Conversation

@EmilyBourne
Copy link
Copy Markdown
Collaborator

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

Always to be checked:

  • There is at least one issue associated with the pull request.
  • New code adheres with the coding guidelines
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

If functions were changed or functionality was added:

  • Tests for new functionality has been added
  • A local test was succesful

If new functionality was added:

  • There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

  • Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

  • Are new methods referenced? Did you provide further documentation?

Checks by code reviewer(s):

  • Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
  • The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
  • There are appropriate unit tests and they pass.
  • The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
  • Coverage report for new code is acceptable.
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

@EmilyBourne EmilyBourne requested a review from julianlitz April 20, 2026 14:38
Copy link
Copy Markdown
Collaborator

@julianlitz julianlitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting everything inside a namespace is a good idea.
Feel free to use GMG:: if you like to or gmgpolar:: depending of what you like best.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.70%. Comparing base (918f0a5) to head (e015040).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #215   +/-   ##
=======================================
  Coverage   90.70%   90.70%           
=======================================
  Files          86       86           
  Lines        9454     9458    +4     
=======================================
+ Hits         8575     8579    +4     
  Misses        879      879           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@julianlitz julianlitz self-requested a review April 20, 2026 16:00
@EmilyBourne
Copy link
Copy Markdown
Collaborator Author

Putting everything inside a namespace is a good idea.

I had problems linking GMGPolar to gyselalib++ mostly due to Vector which is a common name across many code bases.

Feel free to use GMG:: if you like to or gmgpolar:: depending of what you like best.

I have no strong feelings about the name. I chose gmgpolar to reflect the project name but maybe this is sometimes used for an instance of the GMGPolar class?

@EmilyBourne EmilyBourne merged commit 5a935d7 into main Apr 21, 2026
8 checks passed
@EmilyBourne EmilyBourne deleted the ebourne_namespace branch April 21, 2026 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants