Migrated package.manifest*.json to draft-07 - #6060
Open
Vessel9817 wants to merge 5 commits into
Open
Conversation
Vessel9817
commented
Jul 20, 2026
Vessel9817
commented
Contributor
- Migrated from draft-04 to draft-07
- Enabled strict validation
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
hyperupcall
reviewed
Sep 5, 2026
| "description": "A user group alias who is denied access" | ||
| } | ||
| }, | ||
| "required": ["deny"] |
Member
There was a problem hiding this comment.
With the properties moved over inside of oneOf, are these required properties needed anymore? Wondering how their existence changes the schema validation
Contributor
Author
There was a problem hiding this comment.
Not sure I understand what you mean. There's no negative tests or dependencies, so removing required has no effect on tests, but it does make the properties optional. However, I could move the properties back outside oneOf to simplify the diff.
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.