Repository navigation
Types: withheld on roster entries, fueling rollups and AI reports - #30
Open
DrAlexHarrison wants to merge 1 commit into
Open
DrAlexHarrison wants to merge 1 commit into
DrAlexHarrison wants to merge 1 commit into
Conversation
The Coach API sends a withheld notice about an athlete who connected an app whose data stays on Saturday; the types had no field for it. top_reasons is documented as [] for an athlete who is not flagged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RdmWd4TJTQMDjLtmVXcBu1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes, in plain words
The Coach API tells a coach's script when some of an athlete's sessions are left out of an answer (the athlete connected an app whose data stays on Saturday). It sends a
withheldobject on that athlete's roster row, fueling rollup and AI report, and the docs describe it, but the TypeScript types had no field for it, so a script had to cast to read it. They have one now:withheld?: CoachWithheldNotice(kind: 'connected_app_sessions',message).RosterEntry.top_reasonsis documented as[]for an athlete who is not flagged. The API sentnullthere; fuel-backend #1808 makes it[], matching the existingstring[]type.Types only: no runtime change, no request change.
Merge after fuel-backend #1808 lands (left unlabeled; this repo is public).
Checks
npx tsc --noEmit: clean.npx jest: 7 suites, 135 passed, 1 skipped (the sandbox suite, which needs a key).source_attributions) and athletes.getFuelingProfile, the fueling-profile types and the two sharing webhook types #28.🤖 Generated with Claude Code
https://claude.ai/code/session_01RdmWd4TJTQMDjLtmVXcBu1