Repository navigation
Coaching groups and OAuth scopes: two sentences corrected after the #39 review - #41
Merged
Merged
Conversation
… review Smart groups: neither the coach portal nor the Saturday app exposes a manual force-in or force-out control for a smart group (the portal's group manager has no manual member editor for smart groups; the app has no such fields), so the sentence claiming it is removed. The backend field exists but no surface sets it. offline_access: the "and note that" scaffold becomes a standalone sentence. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K9f7KoPEPs8FXwBT8vAduy Ci-From: linux Ci-Session: f2e28bc2-ac58-48e1-a2b8-39bf8e777e80
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two one-line follow-ups from the independent review of #39, both on pages that page merged.
coaching/roster/flags-and-groups.mdx: removed "A smart group can also force specific athletes in or out regardless of the rules." The group model carriesmanual_includes/manual_excludesand the smart-group resolver applies them (fuel-backendpkg/coach/smartgroups/resolve.go), but no surface lets a coach set them: the portal's group manager has no manual member editor for smart groups (coach-portal frontend-next/components/athlete-management/groups-manager.tsx:314), and the Saturday app has no reference to the fields anywhere on main. A coaching page describes what a coach can do, so the sentence goes rather than being re-homed.guides/oauth2.mdx: "Request it alongside your data scopes if you need refresh, and note that it is not included in the defaultathlete:readfallback." becomes two sentences, the second standalone: "It is not included in the defaultathlete:readfallback."Checks run locally on this tree:
check-engine-constants.pyclean (19 allowed matches),check-docs-drift.pyagainst fuel-backend main 53878c7 clean (121 operations, 16 events, 4 baselined).driftandbaseline-shrink-onlywill sit queued on this PR as on every docs PR (docs #36).🤖 Generated with Claude Code
https://claude.ai/code/session_01K9f7KoPEPs8FXwBT8vAduy