Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AssociatePacketConn.WriteToreturns the SOCKS UDP header length together with the payload count. This also affectsWrite, so a seven-byte IPv4 payload reports 17 bytes and an empty payload reports 10.Subtract the serialized header from the underlying write count, clamping incomplete-header writes to zero and preserving the original write error. UDP framing and the buffer-based packet API are unchanged.
Fixes #83.
Validation: real UDP loopback tests exercise
WriteandWriteTo, IPv4/IPv6/domain destinations, and empty/nonempty payloads; controlled write errors cover no bytes, incomplete headers, partial payloads, and complete writes with errors. These regressions fail on currentdevbefore the change.go test -race ./...and Linux golangci-lint pass. Android, Darwin and FreeBSD lint also pass. Windows lint reports the same pre-existing missingt.Parallel()incommon/winiphlpapi/nsi_test.go:34on the base and patch.make testpasses.