Repository navigation
🐛 Heading links - Darken the underline too, and only in red headings - #5146
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the heading-link styling refinements.
No open issues 🎉
What changed in this PR
Refines red heading-link styling to address #5135: hover underlines now darken with the text, while headings with the specified colour overrides retain standard link styling.
Changes:
- Applies
sswDarkRedto both link text and underlines on hover. - Excludes the heading colour overrides used by base pages and the client story dialog.
- Extends the styling to links inside red
h1 > strongheadings.
| File | Description |
|---|---|
styles.css |
Refines heading-link selectors, synchronizes hover colours, and documents override exclusions. |
Review effort: Balanced
Coverage report
Test suite run success134 tests passing in 17 suites. Report generated by 🧪jest coverage report action from 3e5f669 |
|
/deploy 🤖 Comment written by Claude Opus 5.5 via Claude Code |
|
Deployed changes to https://app-sswwebsite-9eb3-pr-5146.azurewebsites.net ℹ️ Staging slots are no longer created automatically - comment |
designbyalex
left a comment
There was a problem hiding this comment.
Thanks @tiagov8. The underline now darkens with the text on hover. Text and underline are both #8e2c2c, which matches the Design System.
Figure: /company/news heading link on hover, production vs this PR
Base pages and the client story dialog now keep the standard link hover, so only red headings darken. I tested this with a link in a black h2 on /code-of-conduct, since no base page has one yet.
Figure: Test link in a black h2 on /code-of-conduct, production vs this PR
Closes #5135
Follow-up to #5137, from @designbyalex's review. When a link in a red heading is hovered, its underline now darkens with the text. The red-link style is also limited to headings that are actually red.
What changed
The underline matches the text on hover. Before, the text went dark red but the global
a:hoverrule kept the underline brand red. Both are nowsswDarkRed(#8e2c2c), matching the Design System's hover pattern.Only red headings get the style. 🐛 Heading links - Keep red heading links red and darken on hover #5137 applied it to every
.prose h2, so links in headings a page recolours turned dark red on hover too. Those pages now keep the standard link style:prose-h2:text-black.prose-headings:text-foregroundandprose-strong:text-foreground.This covers 🐛 Bug - Heading links use incorrect hover styling #5135's AC5: no other standard link styles are affected.
Red
h1 > strongheadings are covered too. They're red in the typography config, the same ash2.Risky areas
styles.cssis global. The rule excludes heading colour overrides by exact class name, so a page that recolours prose headings some other way would still get red links. The comment above the rule says to add new overrides to the:not()lists.prose-h2:text-3xl/9(a size, used bycompanyPageCard) is not excluded, so those red headings keep the red-link style.🤖 Changes made by Claude Opus 5.5 via Claude Code