Skip to content

[autobackport: sssd-2-13] Smartcard multi token tests#8665

Open
sssd-bot wants to merge 1 commit intoSSSD:sssd-2-13from
sssd-bot:SSSD-sssd-backport-pr8519-to-sssd-2-13
Open

[autobackport: sssd-2-13] Smartcard multi token tests#8665
sssd-bot wants to merge 1 commit intoSSSD:sssd-2-13from
sssd-bot:SSSD-sssd-backport-pr8519-to-sssd-2-13

Conversation

@sssd-bot
Copy link
Copy Markdown
Contributor

This is an automatic backport of PR#8519 Smartcard multi token tests to branch sssd-2-13, created by @krishnavema.

Please make sure this backport is correct.

Note

The commits were cherry-picked without conflicts.

You can push changes to this pull request

git remote add sssd-bot git@github.com:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr8519-to-sssd-2-13
git checkout SSSD-sssd-backport-pr8519-to-sssd-2-13
git push sssd-bot SSSD-sssd-backport-pr8519-to-sssd-2-13 --force

Original commits
e5b6597 - tests: implement multi-token support for smart card authentication

Backported commits

  • 318ba3b - tests: implement multi-token support for smart card authentication

Original Pull Request Body

Reviewed-by: Scott Poore <spoore@redhat.com>
Reviewed-by: Sumit Bose <sbose@redhat.com>
(cherry picked from commit e5b6597)
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces system tests for smartcard authentication scenarios involving multiple SoftHSM tokens. It includes a helper function for token setup and three test cases covering scenarios where a valid certificate is on the first token, the second token, or both. A bug was identified in the parametrized test test_smartcard__two_tokens_match_on_both, where attempting to add the same IPA user in multiple iterations would cause a failure; a suggestion was provided to use unique usernames for each iteration.

Comment thread src/tests/system/tests/test_smartcard.py
Copy link
Copy Markdown
Contributor

@sumit-bose sumit-bose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

original and backport matches, ACK.

bye,
Sumit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants