You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
CI Fix - Turn on & fix ui-style and test-vscode CI stages #6004
prettier --check . fails on 4 files — .devcontainer/devcontainer.json, web/client/.../help.ts, web/client/.../ModelNode.tsx, and .github/workflows/pr.yaml itself (two matrix lists in it grew past 80 columns while the job was off).
eslint src tests fails in vscode/extension: tests/lineage_settings.spec.ts imports FrameLocator and Page straight from @playwright/test, which no-restricted-imports blocks for specs. Fixed by re-exporting FrameLocator from tests/fixtures.ts and importing from there, matching what every other spec does with Page.
With those fixed, pnpm run lint (ui-style) and pnpm run ci (test-vscode) both exit 0 locally. Turned the jobs on following #5994, including the vscode paths filter. Left test-vscode-e2e alone per your note.
Activity
cmgoffena13 commentedon Aug 31, 2026
@nickmuoh -- want to tackle this one?
tripleaceme commentedon Sep 11, 2026
Picked this up — PR is open at #6054.
What surfaced once the two stages were back on:
prettier --check .fails on 4 files —.devcontainer/devcontainer.json,web/client/.../help.ts,web/client/.../ModelNode.tsx, and.github/workflows/pr.yamlitself (two matrix lists in it grew past 80 columns while the job was off).eslint src testsfails invscode/extension:tests/lineage_settings.spec.tsimportsFrameLocatorandPagestraight from@playwright/test, whichno-restricted-importsblocks for specs. Fixed by re-exportingFrameLocatorfromtests/fixtures.tsand importing from there, matching what every other spec does withPage.With those fixed,
pnpm run lint(ui-style) andpnpm run ci(test-vscode) both exit 0 locally. Turned the jobs on following #5994, including thevscodepaths filter. Lefttest-vscode-e2ealone per your note.