fix(audit): bind NotificationCommand type T + propagate schedule cid (St#14
Merged
Conversation
…(Story 13.7 gate #3) Carry a single correlation id from the originating schedule through to the notification's terminal audit line, so one id links schedule_fired to notification_sent across the round-trip. - NotificationCommand extends AuditableCommand; ScheduleNotification is now a case class (carries a per-instance cid) and TriggerSchedule4Notification propagates it to the self-sent ScheduleNotification. - Scheduler2NotificationProcessorStream derives the cid from schedule.correlationId (deterministic fallback) and emits schedule_fired / schedule_not_fired / schedule_failed (actor=scheduler). - NotificationBehavior threads the cid (notification.correlationId orElse cmd.correlationId) through sendNotification and stamps it on the notification before send, so notification_sent/_failed carry it; created schedules carry it too (AddNotification / ResendNotification / ScheduleNotification). - NotificationAuditLog promoted to a proper object exposing the shared AuditLog("notification"). - testkit: round-trip assertions (schedule.correlationId == cid) + logback.xml.
…(Story 13.7 Phase B) - NotificationCommand overrides `type T = NotificationCommand` (sound withCorrelationId cast). - TriggerSchedule4Notification: cmd.schedule.correlationId.orElse(cmd.correlationId) so the synthetic stream cid is not dropped by the import-shadowing. - document that the notification_sent/notification_failed 'template' field is N/A at the notification-pod layer. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
==========================================
- Coverage 70.94% 70.56% -0.38%
==========================================
Files 61 61
Lines 1122 1145 +23
Branches 178 174 -4
==========================================
+ Hits 796 808 +12
- Misses 326 337 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ory 13.7 Phase B)
type T = NotificationCommand(sound withCorrelationId cast).synthetic stream cid is not dropped by the import-shadowing.
notification-pod layer.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com