#514 Make the Applications Page Full Width and Codify Page Container Widths - #519
Merged
Merged
Conversation
max-w-6xl was used on this one table page while every sibling list page is full-bleed. loading.tsx carries the same container, so both change or the skeleton shifts width on resolve. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
b-at-neu
added
ready for review
b-at-neu
commented
Aug 19, 2026
b-at-neu
left a comment
b-at-neu
left a comment
Collaborator
Author
There was a problem hiding this comment.
Code Review — Cycle 1 · approved
0 open — clean
b-at-neu
added
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #514
/applicationswas the only page atmax-w-6xl— a centred near-miss width sitting beside four full-bleed table pages (/,/positions,/users,/my-applications,/global-questions). Per.claude/docs/DESIGN.md§4, tables are full-bleed, so the page contradicted its own design doc.Changes
applications/page.tsxandapplications/loading.tsx— dropmx-auto max-w-6xl, leavingflex flex-col gap-6, identical to/users. Both files change together so the skeleton→content transition doesn't shift width..claude/docs/DESIGN.md§4 — the vague**Containers:**bullet is replaced with a checkable three-tier table (full-bleed /max-w-5xl/max-w-2xl), an explicit "no fourth tier" rule, theloading.tsx-must-match rule, and a carve-out for inner prose blocks inside a full-bleed page.No component changes —
applications-toolbar,applications-tableandapplications-bulk-barcontain nomax-w-*or fixed-width classes.Verification
prettier:check,eslint:check,tsc:checkandtest:unit(133 passed) are green. Thedbproject was skipped — no local Postgres;DATABASE_URLpoints at Neon.Static audit confirms every remaining page container matches a documented tier, with zero
max-w-6xlleft in the repo:/,/positions,/users,/applications,/my-applications,/global-questionsmax-w-5xl/applications/[id],/my-applications/[id](page + loading each)max-w-2xl/profile,/positions/[id]/apply,/positions/[id]/edit(page + loading each)app/(legal)/layout.tsxstays atmax-w-3xl— outside the app shell, explicitly excluded by the new rule.Not verified locally — needs a look on the preview
The ticket asks for a visual check at 1280px and ≥1920px. I could not run the app locally: the repo's
.envstill carries the Neon Auth variables and the currentdevbranch requiresBETTER_AUTH_SECRET, so the dev server 500s on every route./applicationsis auth-gated regardless.Worth eyeballing on the Vercel preview:
/applicationsat 1280px and ≥1920px, left edge flush with/userssm:ml-auto) — intentional, matchingusers-table.tsx:157🤖 Generated with Claude Code