#443 Let Users Edit Their Name From The User Dropdown

[cielbellerose]

Closes #443

Summary

• Adds an Edit name item to the user dropdown that opens a FormDialog, pre-filled with the current name, warning that the rename propagates to every application the user has (submitted and decided included).
• Removes the redundant authClient.updateUser sync from the sign-up name step (name-field.tsx) — Better Auth's updateUser writes the same public.User row through the Prisma adapter, so it was a no-op round trip that only ever failed for bypass users.

No new server action, schema, or migration: the dialog submits to the existing setUserName action in prisma/actions/profile.ts, which already authenticates, parses nameSchema, scopes the write to the caller's own record, and revalidates /profile plus the root layout.

Note for review: two of the ticket's acceptance criteria (dropping the resolveRealUser session-name read; public.User.name as the only source of truth) are already satisfied by the prior Better Auth migration — resolveRealUser in lib/auth/server.ts no longer reads a session name at all, since Better Auth owns the User row directly. There's no diff there because there's nothing left to remove.

Changes

• components/features/edit-name-dialog.tsx — new. Client FormDialog wrapper: nameSchema resolver, labelled "Full name" input, WarningCallout with the propagation warning, setUserName call + toasts.
• components/layouts/user-menu.tsx — renders EditNameDialog inside DropdownMenuContent between Profile and Theme, trigger is a DropdownMenuItem with onSelect preventDefault (keeps the dropdown, and the mobile nav Sheet behind it, mounted while the dialog is open); bumped menu item touch targets to min-h-11 on mobile.
• components/features/name-field.tsx — dropped the authClient.updateUser sync call, its toast.warning branch, and the now-unused authClient import.

Testing plan

• Sign in as a normal user → open the user dropdown (desktop sidebar) → Edit name is present and opens a dialog pre-filled with the current name.
• Save a new name → toast "Name updated.", dialog closes, sidebar + dropdown label update without a manual reload.
• Reopen the dialog → pre-filled with the new name.
• Clear the field and submit → inline "Enter your full name.", dialog stays open, no toast.
• Paste 101+ characters and submit → inline max-length error; exactly 100 characters saves.
• Submit a name with leading/trailing spaces → saved trimmed.
• Keyboard only: Tab to the account trigger, Enter, arrow to Edit name, Enter → focus lands in the input; Escape closes the dialog and focus returns to the Edit name item.
• Mobile viewport (~375px): open the hamburger sheet → account menu → Edit name → dialog is usable over the sheet, items are comfortably tappable, and after saving the sheet shows the new name.
• As an admin/manager, open an application submitted by the renamed user (/applications review view) → the applicant name reflects the rename, including on a decided application.
• Dev bypass user (/login/bypass): rename succeeds with only the success toast — no "account sync failed" warning.
• Sign-up path regression: a user with no name signing in via OTP still lands on the /login name step, saving shows "Name saved", and they're redirected to redirectTo.

Automated checks

• npm run prettier:check — pass
• npm run eslint:check — pass
• npm run tsc:check — pass
• npm run test:unit — 71 tests pass (Postgres unavailable locally, npm run test couldn't reach DATABASE_URL)

Notes

• Out of scope, per the ticket: adding this editor to /profile, and any per-application name snapshot — reviewer-facing views intentionally join to User live, so a rename is meant to show up across a user's full application history.
• If Radix ever leaves the page inert after closing the dialog (nested Dialog inside DropdownMenuContent inside, on mobile, Sheet), the fix is modal={false} on the DropdownMenu — not hoisting the dialog out, which would unmount it with the menu/sheet.
• The @radix-ui/react-tooltip dependency and components/ui/tooltip.tsx bundled into this branch's history are an incidental fix for a pre-existing dev-level tsc break (unrelated to this PR's feature), tracked separately as tsc broken on dev: markdown-field.tsx references deleted ui/tooltip #510 and now covered by PR #510 Fix tsc Broken On Dev: Markdown Field Tooltip #512. Once #510 Fix tsc Broken On Dev: Markdown Field Tooltip #512 merges and this PR rebases, this bundled copy will likely need to be reconciled with #510 Fix tsc Broken On Dev: Markdown Field Tooltip #512's canonical version — a resolvable conflict on a file with no PR-specific logic.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
aplio	Ready	Preview	Aug 19, 2026 10:04pm

[cielbellerose]

Code Review — Cycle 1 · approved

0 open — clean

[cielbellerose]

@b-at-neu Is there a reason not to save their current name when they apply just in case? If not this is good to merge

[b-at-neu]

@b-at-neu Is there a reason not to save their current name when they apply just in case? If not this is good to merge

@cielbellerose
There isn't necessarily a reason. If you want to extend the global application answer schema to auto-store their name on each application I think that's fine as well. I don't think people are going to be changing their names that often to something that can't identify them anymore but you're probably right, would be good to save.

[cielbellerose]

Revision — Cycle 4

fixed R4-M1, R4-M2 · c1715f7

[cielbellerose]

Code Review — Cycle 5 · approved

0 open — clean

[cielbellerose]

Rebase conflict resolved

After #512 merged into dev, this branch's incidental bundled copy of components/ui/tooltip.tsx (and its @radix-ui/react-tooltip package.json/lockfile entries) conflicted with #512's now-canonical version — exactly as flagged in this PR's own description.

Resolution: took dev's canonical components/ui/tooltip.tsx (has data-slot attributes matching the current shadcn convention used elsewhere; this branch's copy predated that convention) and dev's package.json/package-lock.json entirely for the tooltip dependency — confirmed via git show 1706d51 -- package.json that this branch's only package.json change was adding that one now-redundant dependency line, so nothing else was at risk of being dropped. npm ci succeeded against the resulting lockfile; prettier/eslint/tsc all pass.

Pushed as b069329.

[cielbellerose]

Code Review — Cycle 6 · approved

0 open — clean