Skip to content

feat: sign in to connectors from their switches and close OAuth popups reliably - #3705

Merged
themaherkhalil merged 1 commit into
devfrom
feat/playground-plus-menu-connectors
Oct 3, 2026
Merged

themaherkhalil merged 1 commit into
devfrom
feat/playground-plus-menu-connectors

Conversation

@themaherkhalil

Copy link
Copy Markdown
Contributor
  • Sign-in popups close as soon as the login is done, wherever the popup lands: the SDK's oauth() and connectLogin share one wait that reads the login while the popup is open, and oauth() fails instead of hanging when the popup is closed or blocked
  • Both popups start with ?disableRedirect=true, so the backend ends the sign-in on a page that closes itself instead of loading an app inside the popup
  • The client signs in through the SDK's oauth() instead of its own copy
  • Connectors settings: switching on an app whose account is not connected signs in and then turns on that app; each account asks to "Sign In with Microsoft" or "Sign In with Google"
  • Add Connectors to the composer's plus menu, opening the Connectors settings page
  • Show the instance's version and build time in a footer on the General settings page

…s reliably

- Sign-in popups close as soon as the login is done, wherever the popup lands: the SDK's oauth()
  and connectLogin share one wait that reads the login while the popup is open, and oauth()
  fails instead of hanging when the popup is closed or blocked
- Both popups start with ?disableRedirect=true, so the backend ends the sign-in on a page that
  closes itself instead of loading an app inside the popup
- The client signs in through the SDK's oauth() instead of its own copy
- Connectors settings: switching on an app whose account is not connected signs in and then
  turns on that app; each account asks to "Sign In with Microsoft" or "Sign In with Google"
- Add Connectors to the composer's plus menu, opening the Connectors settings page
- Show the instance's version and build time in a footer on the General settings page
@themaherkhalil
themaherkhalil requested a review from a team as a code owner October 3, 2026 13:22
@snyk-io

snyk-io Bot commented Oct 3, 2026

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@themaherkhalil
themaherkhalil merged commit acee22d into dev Oct 3, 2026
5 checks passed
@themaherkhalil
themaherkhalil deleted the feat/playground-plus-menu-connectors branch October 3, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant