feat: sign in to connectors from their switches and close OAuth popups reliably - #3705
Merged
Merged
Conversation
themaherkhalil
commented
Oct 3, 2026
Contributor
- Sign-in popups close as soon as the login is done, wherever the popup lands: the SDK's oauth() and connectLogin share one wait that reads the login while the popup is open, and oauth() fails instead of hanging when the popup is closed or blocked
- Both popups start with ?disableRedirect=true, so the backend ends the sign-in on a page that closes itself instead of loading an app inside the popup
- The client signs in through the SDK's oauth() instead of its own copy
- Connectors settings: switching on an app whose account is not connected signs in and then turns on that app; each account asks to "Sign In with Microsoft" or "Sign In with Google"
- Add Connectors to the composer's plus menu, opening the Connectors settings page
- Show the instance's version and build time in a footer on the General settings page
…s reliably - Sign-in popups close as soon as the login is done, wherever the popup lands: the SDK's oauth() and connectLogin share one wait that reads the login while the popup is open, and oauth() fails instead of hanging when the popup is closed or blocked - Both popups start with ?disableRedirect=true, so the backend ends the sign-in on a page that closes itself instead of loading an app inside the popup - The client signs in through the SDK's oauth() instead of its own copy - Connectors settings: switching on an app whose account is not connected signs in and then turns on that app; each account asks to "Sign In with Microsoft" or "Sign In with Google" - Add Connectors to the composer's plus menu, opening the Connectors settings page - Show the instance's version and build time in a footer on the General settings page
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.