feat(sdk): own session logins and move playground off its own cache - #3703
Merged
Merged
Conversation
SDK - Add getLogins, logoutProvider, and connectLogin to api/auth, with PopupBlockedError and SessionLoginDisconnectError - Add a page-wide Logins store and useLogins hook; the insight fills it from the config and resets it after login and logout Playground - Read session logins from the SDK and sign in through Logins.connect - Replace connectors.api.ts with connector-tools.ts, which only reads and writes connector tool files Utility - Move stringifyJsonWithSortedKeys into @semoss/utility/json
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
- Compare and send provider login keys in upper case in connect and disconnect, so a lower-case name cannot sign out the session's login - Drop a logins read still in flight when the session resets - On logout only reset the logins; after a login whose config cannot be read, read the logins on their own - Parse login maps in one place (parseLogins), used for both the logins read and the config - Cover the auth calls and the login and logout wiring with tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDK
Playground
Utility