feat(auth): end popup OAuth logins on a self-closing page with disableRedirect - #441
Merged
Merged
Conversation
themaherkhalil
commented
Oct 3, 2026
themaherkhalil
commented
Collaborator
- An OAuth login started with ?disableRedirect=true keeps the flag in the session across the provider round trip and ends on a small page that closes its window, instead of redirecting the popup to the configured app; every other login redirects as before
- The page sends its own Content-Security-Policy, with a one-time nonce for its script
…eRedirect - An OAuth login started with ?disableRedirect=true keeps the flag in the session across the provider round trip and ends on a small page that closes its window, instead of redirecting the popup to the configured app; every other login redirects as before - The page sends its own Content-Security-Policy, with a one-time nonce for its script
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.