Origin/feature/omh to ros dev - #2
Open
moperezs wants to merge 25 commits into
Open
Conversation
first generalized raw biosignal info converter via mapper
no metadata convertion yet
to allow direct access to the schema
moperezs
commented
Oct 28, 2025
moperezs
left a comment
moperezs
left a comment
Collaborator
Author
There was a problem hiding this comment.
Great work!! It already looks very gueet.
Some general comments:
- Please add an empty line at the end of each file
- Check that all functions have types in inputs and expected outputs
- Did you format the files (e.g. with blackformatter or mypy)? Some lines seem quite long here in git.
- I moved the omh_streamer to the root directory, because it just streams data, which i would separate from converting data.
- From my point of view, conversions should work online and offline. The user should choose whether they implement the library in either case. But I see here you separated online and offline, is there a reason for it?
Collaborator
Author
There was a problem hiding this comment.
I would remove this .gitignore from the repo and let everyone have their custom configs if needed.
Co-authored-by: Monica Perez Serrano <moperez@ethz.ch>
Co-authored-by: Monica Perez Serrano <moperez@ethz.ch>
…Lab/healthcare_common into origin/feature/omhToRosDev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.