fix: destination fetch option XOR typing#6701
Open
davidkna-sap wants to merge 3 commits into
Open
Conversation
davidkna-sap
force-pushed
the
davidkna-sap_fix-service-type
branch
from
7385dda to
e9757cf
Compare
InjunPark-sap
previously approved these changes
Jun 24, 2026
KavithaSiva
requested changes
Jun 28, 2026
KavithaSiva
left a comment
KavithaSiva
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing the bug, I have added some follow-up questions, suggestions.
Comment on lines
+481
to
+483
| type WithoutExclusive<T, U> = { | ||
| [P in Exclude<keyof T, keyof U>]?: never; | ||
| }; |
Contributor
There was a problem hiding this comment.
[req] Consider moving WithoutExclusive to packages/util/src/types.ts and also updating XOR type to start using this type instead.
Although, updating XOR is a breaking change, I believe the update would enforce correct behaviour of the type, for underlying types with shared keys.
@marikaner WDY think?
| * Stripping `destinationName` from `DestinationFetchOptions` and letting the inner discriminated | ||
| * union of `DestinationFromServiceBindingOptions` own that key fixes it. | ||
| */ | ||
| type FetchOptionsLeaf = Omit<DestinationFetchOptions, 'destinationName'> & |
Contributor
There was a problem hiding this comment.
[q] I find the name cryptic, what about DestinationFetchOrServiceOptions instead?
…t-d.ts Co-authored-by: KavithaSiva <kavitha.sivakumar@sap.com>
InjunPark-sap
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/SAP/ai-sdk-js-backlog/issues/598.
The
servicekey was still hidden due to the way types were composed a higher levels.