fix: Refactor HTTP agent cache for better runtime compatibility.#6695
Open
davidkna-sap wants to merge 4 commits into
Open
fix: Refactor HTTP agent cache for better runtime compatibility.#6695davidkna-sap wants to merge 4 commits into
davidkna-sap wants to merge 4 commits into
Conversation
davidkna-sap
commented
Jun 23, 2026
davidkna-sap
changed the title
davidkna-sap
commented
Jun 25, 2026
| ): Promise<string> { | ||
| const stringifiedValue = stringify(value); | ||
| const encodedValue = new TextEncoder().encode(stringifiedValue); | ||
| const hashBuffer = await crypto.subtle.digest('SHA-256', encodedValue); |
Member
Author
There was a problem hiding this comment.
Switched to this as this is a browser API which includes a non-dynamic list of algorithms that are supported: https://developer.mozilla.org/en-US/docs/Web/API/SubtleCrypto/digest#parameters
KavithaSiva
approved these changes
Jul 3, 2026
KavithaSiva
left a comment
KavithaSiva
left a comment
Contributor
There was a problem hiding this comment.
Clean fix! Was this reported by a Cline user hitting the OpenSSL error, or did you discover it another way?
Comment on lines
+163
to
167
| // TODO: Supported in Node.js 25 and later + browsers | ||
| if ((Uint8Array.prototype as any).toHex) { | ||
| // Use toHex if supported. | ||
| return (new Uint8Array(hashBuffer) as any).toHex(); // Convert ArrayBuffer to hex string. | ||
| } |
Contributor
There was a problem hiding this comment.
[pp] I personally prefer to add this later when Node 25 is our default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certain environments with older runtimes (openssl versions) like VSCode may not have
blake2s256. I added some fallbacks.Also get rid of node 20 compatibility handling.
Closes SAP/cloud-sdk-backlog#ISSUENUMBER.