Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
96 commits
Select commit Hold shift + click to select a range
0ffbaaa
8397176: Invalid bytecode generated for varargs method references wit…
Nov 12, 2026
16725ad
8391181: C1: Incorrect execution with EliminateFieldAccess
mhaessig Nov 12, 2026
c44c0d0
8396941: jwebserver uses an unsupported jdk.includeInExceptions category
Nov 12, 2026
013f593
8378527: Evaluate XOopDesc::base_offset_in_bytes return types
caspernorrbin Nov 12, 2026
a6cdd76
8396411: Simplify partial-array state lifetime management
albertnetymk Nov 12, 2026
fe7d4fc
8396879: IconSwap.cpp ChangeIcon has broken NULL-check after malloc
MBaesken Nov 12, 2026
4eecbf8
8396321: [Valhalla] C2 does not scalarize all aliases of early larvals
TobiHartmann Nov 12, 2026
859a452
8396524: C2: compiler/rangechecks/TestFoldComparesFuzzer.java fails a…
Marukohe Nov 12, 2026
a8c28d1
8397214: Problemlist compiler/c1/TestMemoryEffects.java on aarch64
mhaessig Nov 12, 2026
59baecd
8397069: JFR: Duplicated exception events and lost messages
egahlin Nov 12, 2026
d092d75
8389999: Add more AOT tests for value classes
Nov 12, 2026
6ff1487
8397197: RISC-V: Clean up address stub handling
DingliZhang Nov 13, 2026
3c96ada
8395812: serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorMultiA…
shivshah-oracle Nov 13, 2026
eac7b16
8393971: Update Commons BCEL to Version 6.13.0
JoeWang-Java Nov 13, 2026
bb5483e
8396909: [AIX] make test TEST=gtest:... does not work
reinrich Nov 13, 2026
6913119
8396457: C2: Missed Ideal optimization opportunity in PhaseIterGVN fo…
mhaessig Nov 13, 2026
b43590b
8396947: C2: make is/isa/as for Type be like for Node
marc-chevalier Nov 13, 2026
c8ca4d5
8391179: C2: assert(adr_type == nullptr || adr->is_top() || C->get_al…
rwestrel Nov 13, 2026
eed6635
8396267: os_windows.large_page_init_decide_size gtest fails when the …
aprilivy Nov 13, 2026
08bca38
8372153: AArch64: Performance regression in long reduction microbench…
Nov 13, 2026
cf264b8
8389217: CDSHeapVerifier::CheckStaticFields::do_field crashes with nu…
iklam Nov 13, 2026
ce986f7
4617681: Constructor of BufferedImage throws unexpected IllegalArgume…
prrace Nov 13, 2026
d9a41e2
8397098: Typo in warning message for AOTMode=on being deprecated
iklam Nov 13, 2026
05ea9f4
8397370: Disable gtest special_flags until JDK-8397233 is fixed
Nov 13, 2026
78362cb
8393607: java.managment Permission related cleanup
Nov 14, 2026
fa4c5dc
8385659: Shenandoah: Assertions during concurrent mark may encounter …
Nov 14, 2026
455f02e
8397083: Diffs printed by CDS test DeterministicDump.java are incorrect
iklam Nov 14, 2026
2d03a6c
8393068: Optimize uniform vector byte shift operations using x86 GFNI…
Nov 14, 2026
ab68166
8396093: Too many calls to os::same_files() in AOT training
iklam Nov 14, 2026
b3fad4a
8397266: RISC-V: Replace generated CPU feature subclasses with descri…
zifeihan Nov 14, 2026
e63fe67
8397174: RISC-V: Enable gather/scatter and mask-folding IR tests on RVV
zifeihan Nov 14, 2026
64a4ea6
8397386: TestDeadStoreToHeader fails in product build
TheRealMDoerr Nov 15, 2026
3772c33
8392449: Test tools/javac/patterns/Exhaustiveness.java timed out the…
lahodaj Nov 16, 2026
526c79e
8397201: Temporarily exclude java.io package from the SinceChecker test
jaikiran Nov 16, 2026
e3dc4f9
8392568: [GCC static analyzer] potential NULL dereference in XDHD_ADD…
MBaesken Nov 16, 2026
9121672
8397208: [Valhalla] Atomic flat field load omits GC barriers
TobiHartmann Nov 16, 2026
ad645ad
8397215: [Valhalla] JITs incorrectly eliminate volatile accesses to e…
TobiHartmann Nov 16, 2026
523419c
8387963: sspi.cpp drops Kerberos Channel Binding
Nov 16, 2026
ff06897
8369857: Training data for excluded classes should be removed from AO…
Nov 16, 2026
803a2a0
8379683: Implement JEP 535: Shenandoah GC: Generational Mode by Default
Nov 16, 2026
8b66c8b
8397232: Fix incorrect operand types that prevent APX C2 match rules …
Nov 16, 2026
1fa9669
8397004: compiler/codegen/TestCharShortVect.java failed assert(WhiteB…
Nov 16, 2026
5eb8cf6
8395738: [Valhalla] C2: Fix correctness issues with arraycopy intrinsic
chhagedorn Nov 16, 2026
e98c5ca
8375322: Improve DomainKeyStore.java coverage
myankelev Nov 16, 2026
fdd7481
8387162: Enhance Kerberos tickets
wangweij Jul 13, 2026
dbb7e33
8387351: Enhance TLS connections
artur-oracle Jul 17, 2026
87bb8fd
8389830: Enhance JFR Events
egahlin Aug 21, 2026
320b3e5
8387541: Enhance StringBuilder checks
vy Aug 26, 2026
f9ea803
8391225: Test compiler/stringopts/TestStackedConcatsManyUTF16Overflow…
vy Aug 27, 2026
961d492
8391595: [REDO] Enhance JMX Connections
kevinjwalls Sep 25, 2026
d91c47e
8390694: Enhance vector masks
djelinski Oct 8, 2026
529f066
8393456: Improve TLS client connections
Oct 8, 2026
5177a70
8393212: Base64 optimization improvements
TobiHartmann Oct 13, 2026
9686604
8377979: Add new methods to X509Certificate to return Instant instead…
myankelev Nov 16, 2026
eb6ed09
8397267: java/awt/font/FontNames/FCCompositeTest.java fails
prrace Nov 16, 2026
a9867b3
8308026: AsyncGetCallTraceTest fails with virtual threads
shivshah-oracle Nov 16, 2026
a565698
8397456: Parse error with test/hotspot/jtreg/gc/shenandoah/TestVerify…
Nov 17, 2026
618352a
8397031: Update Zlib Data Compression Library to Version 1.4
jaikiran Nov 17, 2026
5ffa0dc
8373114: Redundant MethodCounters in the preimage generated by traini…
Nov 17, 2026
68b09f1
8397369: Add -XX:+AOTStressArchiveUnmapping diagnostic flag
iklam Nov 17, 2026
0936a0e
8396201: VM_HeapWalkOperation::visit can mistake a flattened value fo…
Nov 17, 2026
270be24
8397221: java/net/vthread/BlockingSocketOps.java#no-vmcontinuations o…
Nov 17, 2026
f955855
8397390: [TESTBUG][AIX] SEGV during gtests teardown in ~UnitTestImpl
reinrich Nov 17, 2026
b915a4b
8397443: C2: Optimize a DecodeN of a Phi whose inputs are EncodePs
merykitty Nov 17, 2026
5382e9e
8396170: MalformedFrame.errorStream is unused
rm-gh-8 Nov 17, 2026
d4084b4
8397424: Remove unused macros found on macOS/clang
MBaesken Nov 17, 2026
3ff4e7c
8387705: [Valhalla] Barrier data for StoreLSpecial should be attached…
marc-chevalier Nov 17, 2026
3597f49
8395724: [Valhalla] C2: assert((_type == Type::MEMORY) == (_adr_type …
rwestrel Nov 17, 2026
8b5481d
8397257: Obsolete InitiatingHeapOccupancyPercent
Nov 17, 2026
5f622fc
8396815: C2: Null-safe version of is_XXX / isa_XXX
marc-chevalier Nov 17, 2026
565b073
8397190: Reduce execution time of sun/security/ssl/X509KeyManager/Cer…
coffeys Nov 17, 2026
b068723
Merge
Nov 17, 2026
be2faed
8397265: Shenandoah: Avoid healing nmethod oops on deoptimization path
shipilev Nov 17, 2026
a198e76
8397381: Clean up VM option matching code in filemap.cpp
iklam Nov 18, 2026
89bbffd
8397470: No need to call find_record() in AOTSystemDictionary::copy_u…
iklam Nov 18, 2026
e762367
8397465: RISC-V: Update RVA profile flag defaults and classifications
DingliZhang Nov 18, 2026
8c9e0b1
8397270: Gracefully shutdown poller threads at VM exit
Nov 18, 2026
2b376fb
8397505: NTLM tests are failing after Windows update
djelinski Nov 18, 2026
57f36b3
8397423: C1: CheckCast does not kill memory state when class loading …
TobiHartmann Nov 18, 2026
62e4644
8397199: PKCS12KeyStore throws ArrayIndexOutOfBoundsException for emp…
Nov 18, 2026
98a847d
8397222: ZGC: Ensure alignment when probing MADV_COLLAPSE availability
fisk Nov 18, 2026
493db12
8397210: C2: make some Type methods static
Nov 18, 2026
ed6e499
8396037: PPC64: Remove postalloc expansion from MachConstantBaseNode
dbriemann Nov 18, 2026
21353e5
8397179: [windows] get_path_to_target misses some handle closing
MBaesken Nov 18, 2026
fcc7be9
8396577: Update LCMS to 2.20
jayathirthrao Nov 18, 2026
182eec8
8397396: [TESTBUG] jdk/jfr/event/profiling/TestCPUTimeSamplingStop.ja…
parttimenerd Nov 18, 2026
912f7dc
8397224: Make call to relativize_chunk_concurrently on thaw slow path…
pchilano Nov 18, 2026
7331ea4
8397503: Failing realloc in zip_util.c overwrites variables with NULL…
MBaesken Nov 18, 2026
5146c3c
8396845: ZipOutputStream::writeCEN should validate CEN Header size af…
Nov 18, 2026
3428400
8394644: Float16.valueOf(String) rounding incorrect near subnormal mi…
jddarcy Nov 18, 2026
6fc8c86
8385968: TLS support for Hybrid Key Exchange Provider
Nov 18, 2026
1c8b439
8397444: Add ConcNativeForkTest to jdk_core_manual_no_input test grou…
Nov 18, 2026
7eebd9f
8396855: Shenandoah: Approximate the passive heuristic for single and…
Nov 18, 2026
c663a1e
8397723: [BACKOUT] Disable automatic integer spills to floating point…
Nov 19, 2026
4f33273
8397765: Test runtime/cds/appcds/aotFlags/AOTFlags.java fails after J…
iklam Nov 19, 2026
186489b
8397254: jdk.httpserver uses wall clock to measure elapsed time
vy Nov 19, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
3 changes: 2 additions & 1 deletion make/RunTests.gmk
Original file line number Diff line number Diff line change
Expand Up @@ -526,6 +526,7 @@ define SetupRunGtestTestBody
$$(call MakeDir, $$($1_TEST_RESULTS_DIR) $$($1_TEST_SUPPORT_DIR))
$$(call ExecuteWithLog, $$($1_TEST_SUPPORT_DIR)/gtest, \
$$(CD) $$($1_TEST_SUPPORT_DIR) && \
$(if $(call isTargetOs, aix), LIBPATH=$$(TEST_IMAGE_DIR)/hotspot/gtest/$$($1_VARIANT):$$$$LIBPATH) \
$$(FIXPATH) $$(TEST_IMAGE_DIR)/hotspot/gtest/$$($1_VARIANT)/gtestLauncher \
-jdk $(JDK_UNDER_TEST) $$($1_GTEST_FILTER) \
--gtest_output=xml:$$($1_TEST_RESULTS_DIR)/gtest.xml \
Expand All @@ -545,7 +546,7 @@ define SetupRunGtestTestBody
$$(subst $$(TOPDIR)/, , $$($1_TEST_RESULTS_DIR))))
$$(if $$(wildcard $$($1_RESULT_FILE)), \
$$(eval $1_RUN := $$(shell $$(AWK) \
'/==========.* tests? from .* test (cases?|suites?) ran/ { print $$$$2 }' \
'/\==========.* tests? from .* test (cases?|suites?) ran/ { print $$$$2 }' \
$$($1_RESULT_FILE))) \
$$(if $$($1_RUN), , $$(eval $1_RUN := 0)) \
$$(eval $1_PASSED := $$(shell $$(AWK) '/\[ PASSED \] .* tests?./ \
Expand Down
2 changes: 2 additions & 0 deletions make/hotspot/lib/CompileGtest.gmk
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ $(eval $(call SetupJdkLibrary, BUILD_GTEST_LIBGTEST, \
-I$(GTEST_FRAMEWORK_SRC)/googlemock \
-I$(GTEST_FRAMEWORK_SRC)/googlemock/include, \
CFLAGS_macosx := -DGTEST_OS_MAC=1, \
CFLAGS_aix := -DGTEST_HAS_PTHREAD=1, \
OPTIMIZATION := $(JVM_OPTIMIZATION), \
COPY_DEBUG_SYMBOLS := $(GTEST_COPY_DEBUG_SYMBOLS), \
ZIP_EXTERNAL_DEBUG_SYMBOLS := false, \
Expand Down Expand Up @@ -114,6 +115,7 @@ $(eval $(call SetupJdkLibrary, BUILD_GTEST_LIBJVM, \
-I$(GTEST_FRAMEWORK_SRC)/googlemock/include \
$(addprefix -I, $(GTEST_TEST_SRC)), \
CFLAGS_macosx := -DGTEST_OS_MAC=1, \
CFLAGS_aix := -DGTEST_HAS_PTHREAD=1, \
DISABLED_WARNINGS_gcc := $(DISABLED_WARNINGS_gcc) \
undef stringop-overflow, \
DISABLED_WARNINGS_gcc_test_metaspace_misc.cpp := unused-const-variable, \
Expand Down
50 changes: 17 additions & 33 deletions src/hotspot/cpu/aarch64/aarch64.ad
Original file line number Diff line number Diff line change
Expand Up @@ -1768,11 +1768,6 @@ int ConstantTable::calculate_table_base_offset() const {
return 0; // absolute addressing, no offset
}

bool MachConstantBaseNode::requires_postalloc_expand() const { return false; }
void MachConstantBaseNode::postalloc_expand(GrowableArray <Node *> *nodes, PhaseRegAlloc *ra_) {
ShouldNotReachHere();
}

void MachConstantBaseNode::emit(C2_MacroAssembler* masm, PhaseRegAlloc* ra_) const {
// Empty encoding
}
Expand Down Expand Up @@ -1969,7 +1964,7 @@ uint MachSpillCopyNode::implementation(C2_MacroAssembler *masm, PhaseRegAlloc *r

assert(src_lo != OptoReg::Bad && dst_lo != OptoReg::Bad, "must move at least 1 register");

if (src_hi != OptoReg::Bad && !bottom_type()->isa_pvectmask()) {
if (src_hi != OptoReg::Bad && !bottom_type()->is_pvectmask()) {
assert((src_lo&1)==0 && src_lo+1==src_hi &&
(dst_lo&1)==0 && dst_lo+1==dst_hi,
"expected aligned-adjacent pairs");
Expand All @@ -1984,7 +1979,7 @@ uint MachSpillCopyNode::implementation(C2_MacroAssembler *masm, PhaseRegAlloc *r
int src_offset = ra_->reg2offset(src_lo);
int dst_offset = ra_->reg2offset(dst_lo);

if (bottom_type()->isa_vect() && !bottom_type()->isa_pvectmask()) {
if (bottom_type()->is_vect() && !bottom_type()->is_pvectmask()) {
uint ireg = ideal_reg();
DEBUG_ONLY(int algm = MIN2(RegMask::num_registers(ireg), (int)Matcher::stack_alignment_in_slots()) * VMRegImpl::stack_slot_size);
assert((src_lo_rc != rc_stack) || is_aligned(src_offset, algm), "unaligned vector spill sp offset %d (src)", src_offset);
Expand Down Expand Up @@ -2132,7 +2127,7 @@ uint MachSpillCopyNode::implementation(C2_MacroAssembler *masm, PhaseRegAlloc *r
} else {
st->print("%s", Matcher::regName[dst_lo]);
}
if (bottom_type()->isa_vect() && !bottom_type()->isa_pvectmask()) {
if (bottom_type()->is_vect() && !bottom_type()->is_pvectmask()) {
int vsize = 0;
switch (ideal_reg()) {
case Op_VecD:
Expand Down Expand Up @@ -2626,11 +2621,7 @@ Assembler::Condition to_assembler_cond(BoolTest::mask cond) {

// Binary src (Replicate con)
static bool is_valid_sve_arith_imm_pattern(Node* n, Node* m) {
if (n == nullptr || m == nullptr) {
return false;
}

if (UseSVE == 0 || m->Opcode() != Op_Replicate) {
if (n == nullptr || UseSVE == 0 || !Node::is_exact<Op_Replicate>(m)) {
return false;
}

Expand All @@ -2640,7 +2631,7 @@ static bool is_valid_sve_arith_imm_pattern(Node* n, Node* m) {
}

const Type* t = imm_node->bottom_type();
if (!(t->isa_int() || t->isa_long())) {
if (!(t->is_int() || t->is_long())) {
return false;
}

Expand All @@ -2649,7 +2640,7 @@ static bool is_valid_sve_arith_imm_pattern(Node* n, Node* m) {
case Op_OrV:
case Op_XorV: {
Assembler::SIMD_RegVariant T = Assembler::elemType_to_regVariant(Matcher::vector_element_basic_type(n));
uint64_t value = t->isa_long() ? (uint64_t)imm_node->get_long() : (uint64_t)imm_node->get_int();
uint64_t value = t->is_long() ? (uint64_t)imm_node->get_long() : (uint64_t)imm_node->get_int();
return Assembler::operand_valid_for_sve_logical_immediate(Assembler::regVariant_to_elemBits(T), value);
}
case Op_AddVB:
Expand All @@ -2666,11 +2657,7 @@ static bool is_valid_sve_arith_imm_pattern(Node* n, Node* m) {

// (XorV src (Replicate m1))
static bool is_vector_bitwise_not_pattern(Node* n, Node* m) {
if (n != nullptr && m != nullptr) {
return n->Opcode() == Op_XorV &&
VectorNode::is_all_ones_vector(m);
}
return false;
return Node::is_exact<Op_XorV>(n) && m != nullptr && VectorNode::is_all_ones_vector(m);
}

// Returns true if (n, m) matches "(XorVMask vm2 (MaskAll m1))" and that XorVMask
Expand All @@ -2681,12 +2668,9 @@ static bool is_vector_bitwise_not_pattern(Node* n, Node* m) {
// Limitation: the "andNot" rule still cannot be matched if "m" has other
// uses outside this pattern.
static bool is_vector_mask_not_operand_in_andnot_pattern(Node* n, Node* m) {
if (n == nullptr || m == nullptr) {
return false;
}

if (VectorNode::is_all_ones_vector(m) &&
n->Opcode() == Op_XorVMask &&
if (m != nullptr &&
Node::is_exact<Op_XorVMask>(n) &&
VectorNode::is_all_ones_vector(m) &&
n->outcnt() == 1 &&
n->unique_out()->Opcode() == Op_AndVMask) {
// If another input of the AndVMask is also a mask-not pattern that would
Expand Down Expand Up @@ -8287,8 +8271,8 @@ instruct encodeHeapOop_not_null(iRegNNoSp dst, iRegP src, rFlagsReg cr) %{
%}

instruct decodeHeapOop(iRegPNoSp dst, iRegN src, rFlagsReg cr) %{
predicate(n->bottom_type()->is_ptr()->ptr() != TypePtr::NotNull &&
n->bottom_type()->is_ptr()->ptr() != TypePtr::Constant);
predicate(n->bottom_type()->as_ptr()->ptr() != TypePtr::NotNull &&
n->bottom_type()->as_ptr()->ptr() != TypePtr::Constant);
match(Set dst (DecodeN src));
ins_cost(INSN_COST * 3);
format %{ "decode_heap_oop $dst, $src" %}
Expand All @@ -8301,8 +8285,8 @@ instruct decodeHeapOop(iRegPNoSp dst, iRegN src, rFlagsReg cr) %{
%}

instruct decodeHeapOop_not_null(iRegPNoSp dst, iRegN src, rFlagsReg cr) %{
predicate(n->bottom_type()->is_ptr()->ptr() == TypePtr::NotNull ||
n->bottom_type()->is_ptr()->ptr() == TypePtr::Constant);
predicate(n->bottom_type()->as_ptr()->ptr() == TypePtr::NotNull ||
n->bottom_type()->as_ptr()->ptr() == TypePtr::Constant);
match(Set dst (DecodeN src));
ins_cost(INSN_COST * 3);
format %{ "decode_heap_oop_not_null $dst, $src" %}
Expand Down Expand Up @@ -8388,7 +8372,7 @@ instruct castII_checked(iRegI dst, rFlagsReg cr)

format %{ "# castII_checked of $dst" %}
ins_encode %{
__ verify_int_in_range(_idx, bottom_type()->is_int(), $dst$$Register, rscratch1);
__ verify_int_in_range(_idx, bottom_type()->as_int(), $dst$$Register, rscratch1);
%}
ins_pipe(pipe_slow);
%}
Expand Down Expand Up @@ -8416,7 +8400,7 @@ instruct castII_checked_nosp(iRegINoSp dst, rFlagsReg cr)

format %{ "# castII_checked of $dst" %}
ins_encode %{
__ verify_int_in_range(_idx, bottom_type()->is_int(), $dst$$Register, rscratch1);
__ verify_int_in_range(_idx, bottom_type()->as_int(), $dst$$Register, rscratch1);
%}
ins_pipe(pipe_slow);
%}
Expand All @@ -8441,7 +8425,7 @@ instruct castLL_checked(iRegL dst, rFlagsReg cr)

format %{ "# castLL_checked of $dst" %}
ins_encode %{
__ verify_long_in_range(_idx, bottom_type()->is_long(), $dst$$Register, rscratch1);
__ verify_long_in_range(_idx, bottom_type()->as_long(), $dst$$Register, rscratch1);
%}
ins_pipe(pipe_slow);
%}
Expand Down
93 changes: 87 additions & 6 deletions src/hotspot/cpu/aarch64/aarch64_vector.ad
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,87 @@ source %{
return match_rule_supported_vector(opcode, vlen, bt);
}

// Determine whether the given multiply-add/sub-structured node is a profitable
// vector MLA/MLS candidate.
//
// A multiply-add/sub-structured node is NOT considered a profitable MLA/MLS
// candidate if forming an MLA/MLS would likely extend a dependency chain, e.g.
//
// add_input MulVL MulVL add_input
// \ / \ /
// AddVL/SubVL AddVL
//
// - The "add_input" itself is (or feeds from) another multiply-add/sub-structured
// node or a multiply node.
//
// Exceptions:
// If the "add_input" is identical to one of the multiply operands, then fusing
// does not introduce an additional dependency edge and is allowed.
//
// The main idea behind this change is to improve parallelism between the two inputs
// of AddVL. When "add_input" is MulVL or MLA and has no dependency on MulVL
// (the other input of AddVL), we can benefit from executing add_input and MulVL
// in parallel. However, this parallelism depends on hardware scheduling behavior
// and available resources, so it does not apply uniformly across all microarchitectures.
// Therefore, AvoidMLAChain is applied selectively.
bool Matcher::is_multiply_accumulate_candidate(const Node* n) {
if (n->Opcode() != Op_AddVL && n->Opcode() != Op_SubVL) {
return true;
}
// Only apply the chain-length heuristic to 128-bit vectors.
if (!AvoidMLAChain || Matcher::vector_length_in_bytes(n) != 16) {
return true;
}

Node* in1 = nullptr;
Node* in2 = nullptr;
if (n->is_predicated_vector()) {
// Masked AD rules use (AddVL/SubVL (Binary src1 src2) pg).
assert(n->in(1)->Opcode() == Op_Binary, "");
in1 = n->in(1)->in(1);
in2 = n->in(1)->in(2);
} else {
in1 = n->in(1);
in2 = n->in(2);
}

// Exception:
// If the "add_input" is already needed to compute the "mul", the
// multiply-add/sub-structured node is still considered a profitable vector
// MLA/MLS candidate:
//
// add_input ... ... add_input
// \ \ / \ / /
// \ MulVL MulVL /
// \ / \ /
// AddVL/SubVL AddVL
if (VectorNode::is_unpredicated_vector_long_multiply(in1)) {
if (in2 == in1->in(1) || in2 == in1->in(2)) {
return true;
}
}
if (VectorNode::is_unpredicated_vector_long_multiply(in2)) {
if (in1 == in2->in(1) || in1 == in2->in(2)) {
return true;
}
}

// If both inputs are already long-mul(-add/sub) patterns, fusing again tends
// to lengthen chains.
if (VectorNode::is_vector_long_mul_or_muladdsub(in1) &&
VectorNode::is_vector_long_mul_or_muladdsub(in2)) {
return false;
}

// If an input is a Phi, check whether *its* incoming values are long-mul patterns.
if (VectorNode::phi_has_vector_long_mul_or_muladdsub_input(in1) ||
VectorNode::phi_has_vector_long_mul_or_muladdsub_input(in2)) {
return false;
}

return true;
}

bool Matcher::vector_needs_partial_operations(Node* node, const TypeVect* vt) {
// 1. Only SVE requires partial vector operations.
// 2. The vector size in bytes must be smaller than MaxVectorSize.
Expand Down Expand Up @@ -476,11 +557,11 @@ source %{
// On architectures that do not support predicate, masks are stored in
// general vector registers (TypeVect) with sizes ranging from TypeVectA
// to TypeVectX based on the vector size in bytes.
assert(vt->isa_pvectmask() == nullptr, "mask type is not matched");
assert(!vt->is_pvectmask(), "mask type is not matched");
return false;
}

assert(vt->isa_pvectmask() != nullptr, "expected TypePVectMask on SVE");
assert(vt->is_pvectmask(), "expected TypePVectMask on SVE");
switch (opcode) {
case Op_VectorMaskToLong:
case Op_VectorLongToMask:
Expand Down Expand Up @@ -2972,7 +3053,7 @@ instruct vmla(vReg dst_src1, vReg src2, vReg src3) %{
%}

instruct vmlaL(vReg dst_src1, vReg src2, vReg src3) %{
predicate(UseSVE > 0);
predicate(UseSVE > 0 && Matcher::is_multiply_accumulate_candidate(n));
match(Set dst_src1 (AddVL dst_src1 (MulVL src2 src3)));
format %{ "vmlaL $dst_src1, $src2, $src3" %}
ins_encode %{
Expand All @@ -2984,7 +3065,7 @@ instruct vmlaL(vReg dst_src1, vReg src2, vReg src3) %{
%}

instruct vmla_masked(vReg dst_src1, vReg src2, vReg src3, pRegGov pg) %{
predicate(UseSVE > 0);
predicate(UseSVE > 0 && Matcher::is_multiply_accumulate_candidate(n));
match(Set dst_src1 (AddVB (Binary dst_src1 (MulVB src2 src3)) pg));
match(Set dst_src1 (AddVS (Binary dst_src1 (MulVS src2 src3)) pg));
match(Set dst_src1 (AddVI (Binary dst_src1 (MulVI src2 src3)) pg));
Expand Down Expand Up @@ -3063,7 +3144,7 @@ instruct vmls(vReg dst_src1, vReg src2, vReg src3) %{
%}

instruct vmlsL(vReg dst_src1, vReg src2, vReg src3) %{
predicate(UseSVE > 0);
predicate(UseSVE > 0 && Matcher::is_multiply_accumulate_candidate(n));
match(Set dst_src1 (SubVL dst_src1 (MulVL src2 src3)));
format %{ "vmlsL $dst_src1, $src2, $src3" %}
ins_encode %{
Expand All @@ -3075,7 +3156,7 @@ instruct vmlsL(vReg dst_src1, vReg src2, vReg src3) %{
%}

instruct vmls_masked(vReg dst_src1, vReg src2, vReg src3, pRegGov pg) %{
predicate(UseSVE > 0);
predicate(UseSVE > 0 && Matcher::is_multiply_accumulate_candidate(n));
match(Set dst_src1 (SubVB (Binary dst_src1 (MulVB src2 src3)) pg));
match(Set dst_src1 (SubVS (Binary dst_src1 (MulVS src2 src3)) pg));
match(Set dst_src1 (SubVI (Binary dst_src1 (MulVI src2 src3)) pg));
Expand Down
Loading
Loading