Repository navigation
Raise SaicApiClosedException when a closed client is reused - #32
Merged
Merged
Conversation
This was referenced Oct 17, 2026
Merged
nanomad
added a commit
that referenced
this pull request
Oct 19, 2026
* Add close() to release the underlying httpx.AsyncClient (#31) Closes #28 * Raise SaicApiClosedException when a closed client is reused (#32) * Upgrade dependencies (#37) * Upgrade dependencies Bump dev tool constraints (pytest 9, pytest-asyncio 1, pytest-cov 7, mypy 2, pylint 4, ruff 0.17) and refresh the lock file, which clears the open Dependabot alerts on transitive dependencies. Ignore the new ruff rules CPY001 and ICN001. * Keep the tenacity floor at 9.0.0 * Bump GitHub Actions, test on Python 3.14, add Dependabot (#38) * Bump GitHub Actions, test on Python 3.14, add Dependabot * Update pre-commit hooks * Bump version to 0.10.0 (#39) * Require Python 3.12 and use PEP 695 type parameters (#40) * Test on Python 3.15 (#41) * chore: update lock file dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #31. After
close(),SaicApiClient.send()now raisesSaicApiClosedExceptioninstead of the generic httpxRuntimeError. The retry policy does not retry it. Adds a test and fixes lint intests/test_close.py.