Skip to content

mul_mod_special panics for c = 0 in one-limb implementations #1281

Description

@tob-joe

mul_mod_special is documented as computing multiplication modulo the special modulus p = MAX + 1 - c, i.e. 2^bits - c.

When c = 0, that modulus is 2^bits, so the expected result is ordinary fixed-width wrapping multiplication:

(a * b) mod 2^bits == a.wrapping_mul(b)

The one-limb fixed and boxed implementations instead reach a reduction path that constructs NonZero<Limb> from 0:

NonZero::<Limb>::new_unwrap(Limb::ZERO.wrapping_sub(c))

With c = 0, this panics with invalid value: zero. This affects Uint<1>::mul_mod_special and one-limb BoxedUint::mul_mod_special. Wider inputs already naturally behave like wrapping multiplication for this c = 0 power-of-two modulus case.

Expected behavior: mul_mod_special(..., Limb::ZERO) should return the same value as wrapping_mul for the same precision.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions