You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
belt-dwp currently uses a vendored version of the ghash code with small tweaks required by the specification. We probably should tweak ghash accordingly and migrate belt-dwp to it.
xor_s is useless. It is replaced with just update_padded.
But now I have some problems with little endian/big endian.
Should I add flavors for arithmetic in the polyval crate?
Activity
makavity commentedon Mar 29, 2025
Looks like we should add Le an Be operations, right?
newpavlov commentedon Mar 31, 2025
I don't remember. I will need to take a look at the
belt-dwpspec and compare it against implementation inghash.makavity commentedon Mar 31, 2025
Additional functionality in belt-dwp is only xor_s. If it is ok to add this function in GHash crate and add le or be flavor - can commit it.
newpavlov commentedon Apr 1, 2025
Could you open two PRs for
ghashand forbelt-dwpwith migration to it? You can use the dependency patching for the second PR.makavity commentedon Apr 1, 2025
Yeah, sure.
makavity commentedon Jun 4, 2025
xor_sis useless. It is replaced with justupdate_padded.But now I have some problems with little endian/big endian.
Should I add flavors for arithmetic in the
polyvalcrate?newpavlov commentedon Jun 4, 2025
Yeah, it's probably has to be done.
makavity commentedon Sep 9, 2026
Done in #878