Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Issue(s) closed by this pull request: closes #3068
What
_load_data_from_csv()method fromInputManagerwas made public so it could be referenced to load previous simulation ROI data.Why
Ensures ROI is functioning and available for future iterative expansion and extension.
How
compare_roiboolean androi_comparison_pathsdictionary for locating previous roi-calculation data.PartialBudgetmodule, where a partial budget calculation is requested, the economic outputs are logged as before but now there is a check on the new inputs listed above.compare_roito betrue(default isfalse), then the current simulation ROI will be calculated based on the roi formula in theEconomicMetricsmodule. Once calculated, the pathways the user provided in the inputs will be looked up for comparison.Test plan
Step by step process:
{ "name": "ROI INPUTS", "filters": [ ".*econ_pba_summary.*" ] }This will capture a set of economic outputs that looks like this:

RevenueTotalandCostTotal. I went to theeconomic_inputs.jsonfile (input > data > EEE > economic_inputs.json) and upped the numbers for each of theAnimalinputs like this:economic_inputs.json, go to the end of the file and:compare_roifromfalse->trueroi_comparison_pathssection accordingly. Thenameis whatever you want to call the outputs from the first simulation run. I just named itbase_freestall_costs_and_revenuebut it can be whatever you want.addresssection needs to be updated to be a relative path to the output file generated from the filter in the first simulation you ran. The address in there currently is specific to my output file so please be sure to update it to your output file.{ "name": "Net ROI", "filters": [ ".*roi_delta_for_.*" ], "use_verbose_report_name": true }Input Changes
economic_outputs.jsonAdded:
Output Changes
Filter