Repository navigation
Merge upstream changes to main - #9
Open
matthijswolters-rl wants to merge 10 commits into
Open
matthijswolters-rl wants to merge 10 commits into
matthijswolters-rl wants to merge 10 commits into
Conversation
* WIP add config option * Update controller-gen version Fixes the broken v0.9 of controller-gen because it causes a segfault when running `make install` * Update formatting for base CRDS * Working read secret * Fixed read secret * Use new secret function not client function * Revert random formatting changes * More stupid formatting fixes * Final formatting fixes I don't like formatting :( * Small fixes and docs update * Update example * Update CRDs * Include explicit checking of keys * Annotations update #2
* WIP add config option * Update controller-gen version Fixes the broken v0.9 of controller-gen because it causes a segfault when running `make install` * Update formatting for base CRDS * Working read secret * Fixed read secret * Use new secret function not client function * Revert random formatting changes * More stupid formatting fixes * Final formatting fixes I don't like formatting :( * Small fixes and docs update * Update example * Update CRDs * Add raw_post_data var to statuscake * Add user_agent var to statuscake * Update formatting for user_agent * Fix tabs in statuscake-monitor.go * Update base crds * Docs and example update * Update CRDs
* WIP add config option * Update controller-gen version Fixes the broken v0.9 of controller-gen because it causes a segfault when running `make install` * Update formatting for base CRDS * Working read secret * Fixed read secret * Use new secret function not client function * Revert random formatting changes * More stupid formatting fixes * Final formatting fixes I don't like formatting :( * Small fixes and docs update * Update example * Update CRDs * Add raw_post_data var to statuscake * Add user_agent var to statuscake * Update formatting for user_agent * Fix tabs in statuscake-monitor.go * Update base crds * Docs and example update * Update CRDs * Implement Equals function using TestTags It is mentioned in a comment in the code itself but because of the discrepency between the fields in the EndpointMonitor CR and the Statuscake API it is not immediately clear how to compare an old monitor with an updated monitor. The way I have elected to check this is to use the TestTags field to include some kind of identifier that should be updated on any change. So if the tags have changed then the monitor should be updated.
* WIP add config option * Update controller-gen version Fixes the broken v0.9 of controller-gen because it causes a segfault when running `make install` * Update formatting for base CRDS * Working read secret * Fixed read secret * Use new secret function not client function * Revert random formatting changes * More stupid formatting fixes * Final formatting fixes I don't like formatting :( * Small fixes and docs update * Update example * Update CRDs * Add raw_post_data var to statuscake * Add user_agent var to statuscake * Update formatting for user_agent * Fix tabs in statuscake-monitor.go * Update base crds * Docs and example update * Update CRDs * Implement Equals function using TestTags It is mentioned in a comment in the code itself but because of the discrepency between the fields in the EndpointMonitor CR and the Statuscake API it is not immediately clear how to compare an old monitor with an updated monitor. The way I have elected to check this is to use the TestTags field to include some kind of identifier that should be updated on any change. So if the tags have changed then the monitor should be updated. * Test PUSH CI * Remove unnecessary CI * Fix username and registry link * Remove testing branch * Delete commented stuff
To prevent rate limiting with StatusCake two new things have been introduced. First of all, we cache the results of the GetAll function, so that it does not have to retrieve the status monitors everytime. Secondly, I added a latency after adding a monitor. Because even when the results are cached, if several monitors have to be added in a row, it will be invalidated and still hit the rate limit.
* Add timeout to statuscake endpointmonitor StatusCake allows the user to set a timeout. I added it to the configuration to enable users of IngressMonitorController to add/change it as well. --------- Co-authored-by: Tom Hemmes <tom.hemmes@rosemanlabs.com>
… into stakater-master-fix
robinderooij-rl
force-pushed
the
master
branch
from
September 23, 2026 10:22
bd9e304 to
b31dca6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once this changes have been validated we can swap back to the upstream repo and delete our fork
https://github.com/RosemanLabs/RL-Development/issues/6342