setting: CI 및 에이전트 워크플로우 기준 정리 - #6
Merged
Merged
Conversation
📝 WalkthroughSummary by CodeRabbit
Walkthrough11개의 프론트엔드 작업 유형별 에이전트 스킬 문서와 Changes에이전트 스킬 워크플로 문서
CI 및 런타임 버전 설정
Estimated code review effort: 2 (Simple) | ~15 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 7
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.agents/skills/pr-prep-workflow/SKILL.md:
- Line 15: Remove the duplicated branch and commit convention definitions from
pr-prep-workflow/SKILL.md around lines 36-46, leaving only a concise reference
to project-conventions-workflow/SKILL.md as the single source of truth. Update
the line-15 guidance if needed so it clearly directs readers to that document
without restating formats, examples, or commit types.
In @.agents/skills/project-conventions-workflow/agents/openai.yaml:
- Around line 1-4: Update the metadata for the Project Conventions Workflow by
adding the policy.allow_implicit_invocation setting with a true value alongside
the existing interface definition, preserving the current display_name,
short_description, and default_prompt.
In @.agents/skills/project-conventions-workflow/SKILL.md:
- Around line 54-60: Update the no-issue-number guidance in the branch rules
near the work-branch format so it no longer permits or defines a no-issue branch
name; require asking the user to create or link an issue before proposing a
branch. Keep the required <type>/<issue-number>-<english-slug> format and
existing naming restrictions consistent with AGENTS.md.
In @.github/workflows/ci.yml:
- Line 25: Pin the GitHub Actions in ci.yml to specific commit SHAs for security
and reproducibility. Replace the version tag references for actions/checkout,
pnpm/action-setup, and actions/setup-node (currently using `@v4` format) with
their corresponding 40-character commit SHAs. Include the original version tag
as a comment after each commit SHA reference to maintain documentation of which
version was used.
- Around line 24-25: Update the actions/checkout@v4 step in the CI workflow to
set persist-credentials to false, ensuring the checkout does not retain
GITHUB_TOKEN in .git/config for later pnpm lint and pnpm build JavaScript
execution.
In `@docs/agent/index.md`:
- Around line 11-21: Synchronize the Included Skills table in the documentation
entry point with AGENTS.md by adding server-client-boundary-workflow,
shared-component-workflow, form-flow-workflow, and frontend-fundamentals-review,
preserving the existing skill descriptions and table format.
- Around line 23-27: Update the “Excluded From The Light Setup” section to
remove the external “DONGCHIMI-CLIENT” repository reference and explain
directly, using this repository’s context, that the listed workflows are not
included because this is currently a single Next.js Admin app; retain the
guidance to add them when they become part of everyday work.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 814e0292-2803-4cca-802e-1103ff8aacdd
⛔ Files ignored due to path filters (1)
.coderabbit.yamlis excluded by!.coderabbit.yamland included by none
📒 Files selected for processing (27)
.agents/skills/api-integration-workflow/SKILL.md.agents/skills/api-integration-workflow/agents/openai.yaml.agents/skills/form-flow-workflow/SKILL.md.agents/skills/form-flow-workflow/agents/openai.yaml.agents/skills/frontend-fundamentals-review/SKILL.md.agents/skills/frontend-fundamentals-review/agents/openai.yaml.agents/skills/frontend-quality-verification/SKILL.md.agents/skills/frontend-quality-verification/agents/openai.yaml.agents/skills/frontend-task-orchestrator/SKILL.md.agents/skills/frontend-task-orchestrator/agents/openai.yaml.agents/skills/issue-workflow/SKILL.md.agents/skills/issue-workflow/agents/openai.yaml.agents/skills/page-feature-workflow/SKILL.md.agents/skills/page-feature-workflow/agents/openai.yaml.agents/skills/pr-prep-workflow/SKILL.md.agents/skills/pr-prep-workflow/agents/openai.yaml.agents/skills/project-conventions-workflow/SKILL.md.agents/skills/project-conventions-workflow/agents/openai.yaml.agents/skills/server-client-boundary-workflow/SKILL.md.agents/skills/server-client-boundary-workflow/agents/openai.yaml.agents/skills/shared-component-workflow/SKILL.md.agents/skills/shared-component-workflow/agents/openai.yaml.github/workflows/ci.yml.node-versionAGENTS.mddocs/agent/index.mdpackage.json
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.agents/skills/project-conventions-workflow/SKILL.md (1)
50-59: 📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win브랜치·커밋 규칙의 단일 출처를 유지하세요.
AGENTS.mdLines 67-98과 이 파일 Lines 50-119가 브랜치 형식, 금지 문자, 커밋 형식, 타입 목록, 본문 규칙을 각각 정의합니다. 한 문서만 상세 규칙의 source of truth가 되어야 합니다. 현재 구조는 한 문서만 변경될 때 에이전트가 서로 다른 규칙을 적용할 위험이 있습니다. 이 skill을 단일 출처로 유지하고AGENTS.md에는 짧은 참조만 남기세요.As per path instructions:
.agents/**skill은AGENTS.md와 중복되거나 충돌하는 source of truth를 만들지 않아야 합니다.Also applies to: 62-119
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.agents/skills/project-conventions-workflow/SKILL.md around lines 50 - 59, Make `.agents/skills/project-conventions-workflow/SKILL.md` the sole detailed source of truth for the Branch Naming and commit convention rules. Remove the duplicated branch, commit, type, character, and body requirements from `AGENTS.md`, replacing them with a brief reference to this skill. Preserve the complete rules in the skill without introducing conflicting guidance.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In @.agents/skills/project-conventions-workflow/SKILL.md:
- Around line 50-59: Make `.agents/skills/project-conventions-workflow/SKILL.md`
the sole detailed source of truth for the Branch Naming and commit convention
rules. Remove the duplicated branch, commit, type, character, and body
requirements from `AGENTS.md`, replacing them with a brief reference to this
skill. Preserve the complete rules in the skill without introducing conflicting
guidance.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 7bf38cc9-e8bd-45fd-9cad-4d57f0085ad7
📒 Files selected for processing (5)
.agents/skills/pr-prep-workflow/SKILL.md.agents/skills/project-conventions-workflow/SKILL.md.agents/skills/project-conventions-workflow/agents/openai.yaml.github/workflows/ci.ymldocs/agent/index.md
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
AGENTS.md (1)
24-24: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win패키지 관리자 기준에
package.json#packageManager를 포함해 주세요.Line 24는 lockfile과 scripts만 source of truth로 지정합니다. 제공된
package.json은pnpm@10.33.0을 선언합니다. 이 설정을 포함하지 않으면 다른 pnpm 버전이 선택되어 lockfile 동작이 달라질 수 있습니다.수정 예시
-- Package manager source of truth: existing lockfile and scripts. This repo currently uses `pnpm-lock.yaml`. +- Package manager source of truth: the repository package-manager configuration (`package.json#packageManager`), `pnpm-lock.yaml`, and existing scripts.저장소 지침과 제공된
package.json설정을 기준으로 판단했습니다.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@AGENTS.md` at line 24, Update the package manager source-of-truth guidance in AGENTS.md to include the package.json packageManager field alongside the existing lockfile and scripts, preserving the declared pnpm@10.33.0 configuration as the version to use.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@AGENTS.md`:
- Line 24: Update the package manager source-of-truth guidance in AGENTS.md to
include the package.json packageManager field alongside the existing lockfile
and scripts, preserving the declared pnpm@10.33.0 configuration as the version
to use.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: c67a3034-1e0c-48fc-8849-2b9410acf837
📒 Files selected for processing (1)
AGENTS.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISSUE 🔗
close #5
What is this PR? 🔍
AGENTS.md를 정리했습니다..agents/skills에 필요한 에이전트 스킬만 라이트하게 추가했습니다.docs/agent/index.md에 현재 에이전트 구성을 정리했습니다..github/workflows/ci.yml을 현재 단일 Next.js Admin 프로젝트에 맞게 경량화했습니다.format:check,lint,build검증 유지<type>/<issue-number>-<english-slug>형식으로 정리하고,#사용 금지 규칙을 추가했습니다.Screenshot 📷
Test Checklist ✔
git diff --checkpnpm format:checkpnpm lintpnpm build