[Feat] Enable structured task suggestions beyond automations - #2325
Draft
roomote-roomote[bot] wants to merge 1 commit into
Draft
[Feat] Enable structured task suggestions beyond automations#2325roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
| conversation, | ||
| messageId: posted.messageId, | ||
| }); | ||
| if (suggestions.length > 0) { |
Contributor
There was a problem hiding this comment.
The reply has already reached Discord when this awaited card publish can fail. That rejection bubbles through postReply, so the closeout is neither persisted nor marked delivered; a model retry or durable resume can resend the narrative even though users already saw it. Treat card posting as a non-fatal second phase here (as the stream/retry path does) and return a delivery warning instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
No linked issue. This is an independently requested expansion of the existing structured suggestion capability, based on
developwithout incorporating or depending on #2309.Why this PR exists
Structured suggestions were restricted to automation turns, and ordinary Fast reply adapters did not publish their cards. Task origin should not determine whether useful follow-up work can be offered through the existing acceptance flow.
What changed
The impact is broader availability of the same launchable cards, not broader launch authority. Unsupported surfaces still cannot promise card launching, and delegated workers continue reporting privately through their parent Session.
How it was tested
Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changesetThe exact full lint/typecheck commands above were not run; package typechecks, scoped formatting, and the complete pre-push static gates passed. No changeset was added.