[Chore] Guard review notification identity and target boundaries - #2323
Open
roomote-roomote[bot] wants to merge 1 commit into
Open
[Chore] Guard review notification identity and target boundaries#2323roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
September 7, 2026 14:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Regression coverage for #2281. No separate issue.
Why this PR exists
What changed
Add tests around linked review notification identity and target boundaries. The runtime fix already landed in #2281: send/steer handlers resolve the current run actor or durable task owner instead of rejecting a userless mint-time token. This PR is tests-only and does not change task access, impersonate a user, or duplicate that fix.
The benefit is regression protection, not a new production behavior. Existing structural handoff failures still return 500; this PR deliberately does not redesign their status codes or ordinary task-message authorization.
How it was tested
pnpm exec dotenvx run -f .env.test -- pnpm --filter @roomote/api exec vitest run src/handlers/tasks/__tests__/sendMessageUserContext.test.ts src/handlers/tasks/__tests__/sendMessageToTask.test.ts src/handlers/tasks/__tests__/fastSessionTaskCommunication.test.ts src/handlers/tasks/__tests__/acting-user-sync.test.ts src/__tests__/route-policy-enforcement.test.ts: 94 tests passed in five suites, including existing resume and actor-preservation coverage.pnpm --filter @roomote/api check-typesandgit diff --checkpassed. Normal pre-commit and pre-push gates passed, including oxlint, residual ESLint, all 27 fast typecheck tasks, and Knip (existing non-failing Mint configuration hint).Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locally (focused API tsc and normal repository push gates passed; full commands not run)pnpm changeset(not applicable: tests only)