Skip to content

feat: enable screen sharing on external calls - #40211

Draft
pierre-lehnen-rc wants to merge 7 commits into
developfrom
feat/enable-screen-sharing-on-sip-calls
Draft

feat: enable screen sharing on external calls#40211
pierre-lehnen-rc wants to merge 7 commits into
developfrom
feat/enable-screen-sharing-on-sip-calls

Conversation

@pierre-lehnen-rc

@pierre-lehnen-rc pierre-lehnen-rc commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Proposed changes (including videos or screenshots)

Enables the screen-sharing functionality on external calls.

Issue(s)

DMV-44

Steps to test or reproduce

Further comments

Partially merged to develop through: #41366 #41369 #41372 #41654 #41670

@dionisio-bot

dionisio-bot Bot commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot

changeset-bot Bot commented Apr 17, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 955b5bb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ebb2f1a1-5315-4200-9bce-76d47e610f27

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Apr 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.77%. Comparing base (b60e6c0) to head (955b5bb).

Additional details and impacted files

Impacted file tree graph

@@                             Coverage Diff                             @@
##           chore/mutate-local-sdps-add-content-tag   #40211      +/-   ##
===========================================================================
- Coverage                                    68.80%   68.77%   -0.03%     
===========================================================================
  Files                                         4156     4156              
  Lines                                       159789   159789              
  Branches                                     28040    28092      +52     
===========================================================================
- Hits                                        109936   109893      -43     
- Misses                                       44677    44703      +26     
- Partials                                      5176     5193      +17     
Flag Coverage Δ
e2e 58.89% <ø> (+0.04%) ⬆️
e2e-api 45.69% <ø> (-0.31%) ⬇️
unit 70.75% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pierre-lehnen-rc
pierre-lehnen-rc changed the base branch from chore/p2p-stream-id-syncing to develop May 28, 2026 18:07
@pierre-lehnen-rc
pierre-lehnen-rc force-pushed the feat/enable-screen-sharing-on-sip-calls branch from 28da505 to 2eda56b Compare June 1, 2026 15:44
@pierre-lehnen-rc
pierre-lehnen-rc force-pushed the feat/enable-screen-sharing-on-sip-calls branch from 2eda56b to d187149 Compare June 1, 2026 15:52
@pierre-lehnen-rc pierre-lehnen-rc added this to the POC-VOICE milestone Jun 1, 2026
@ggazzo
ggazzo force-pushed the feat/enable-screen-sharing-on-sip-calls branch 2 times, most recently from 40755c5 to 10fd178 Compare June 24, 2026 21:20
@ggazzo
ggazzo force-pushed the feat/enable-screen-sharing-on-sip-calls branch from 10fd178 to 9c35e9b Compare July 3, 2026 13:24
@pierre-lehnen-rc
pierre-lehnen-rc changed the base branch from develop to dmv/develop July 15, 2026 02:22
@pierre-lehnen-rc
pierre-lehnen-rc force-pushed the feat/enable-screen-sharing-on-sip-calls branch from e495de1 to e25cef2 Compare August 3, 2026 17:12
@pierre-lehnen-rc
pierre-lehnen-rc changed the base branch from dmv/develop to chore/mutate-local-sdps-add-content-tag August 3, 2026 17:13
@pierre-lehnen-rc
pierre-lehnen-rc force-pushed the feat/enable-screen-sharing-on-sip-calls branch 2 times, most recently from eeb438d to da18e4b Compare August 3, 2026 17:15
@pierre-lehnen-rc
pierre-lehnen-rc force-pushed the feat/enable-screen-sharing-on-sip-calls branch from af476f3 to 955b5bb Compare August 18, 2026 19:53
Base automatically changed from chore/mutate-local-sdps-add-content-tag to develop August 19, 2026 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant