Skip to content

fix: allow retrying/deleting stuck (TEMP) messages #7561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deepak0x wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: allow retrying/deleting stuck (TEMP) messages #7561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/containers/message/stores/MessageStore.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ export const useThreadPosition = (): { isThreadReply: boolean; isThreadSequentia
export const useMessageStatus = (): { hasError: boolean; isTemp: boolean } =>
useMessageStore(
useShallow(s => ({
hasError: s.item.status === messagesStatus.ERROR,
hasError: s.item.status === messagesStatus.ERROR || s.item.status === messagesStatus.TEMP,
isTemp: s.item.status === messagesStatus.TEMP || s.item.status === messagesStatus.ERROR
}))
);
Expand Down
4 changes: 2 additions & 2 deletions app/containers/message/stores/__tests__/MessageStore.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,10 +383,10 @@ describe('MessageStore', () => {
expect(latest()).toEqual({ hasError: true, isTemp: true });
});

it('useMessageStatus returns hasError false and isTemp true for a TEMP status model', () => {
it('useMessageStatus returns hasError true and isTemp true for a TEMP status model', () => {
const model = buildFakeModel({ status: messagesStatus.TEMP });
const { latest } = renderDerived(model, useMessageStatus);
expect(latest()).toEqual({ hasError: false, isTemp: true });
expect(latest()).toEqual({ hasError: true, isTemp: true });
});

it('useIsEncrypted returns true for a pending e2e message', () => {
Expand Down