fix: restore breathing room between traffic lights and first tab (CORE-2312) - #3418
Open
jeanfbrito wants to merge 1 commit into
Open
fix: restore breathing room between traffic lights and first tab (CORE-2312)#3418jeanfbrito wants to merge 1 commit into
jeanfbrito wants to merge 1 commit into
Conversation
The round-4 leading-padding reduction also shrank the gap after the macOS traffic lights; widen the traffic-light spacer so the gap returns to its reviewed width while keeping the 4px tab-area padding.
Contributor
WalkthroughThe TabBar traffic light spacer now uses an 82px width when expanded, while retaining a 0px width when collapsed. ChangesTab bar layout
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
macOS installer download |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #3413 (CORE-2312 design review): the round-4 leading-padding reduction also shrank the breathing room between the macOS traffic lights and the first workspace tab.
Changes
Testing
npx tsc --noEmit, eslint cleanSummary by CodeRabbit