fix: Tooltip shows trailing space for formatters without keyboard shortcut#1281
Open
deepak0x wants to merge 2 commits intoRocketChat:developfrom
Open
Conversation
…tcut The template literal unconditionally included a space before the shortcut expression, so formatters without a keyboard shortcut (strike, code, multiline) rendered their tooltip as e.g. 'strike ' instead of 'strike'. Replace with a ternary so the space and parentheses are only added when a shortcut is present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Tooltip shows trailing space for formatters without keyboard shortcut
Acceptance Criteria fulfillment
packages/react/src/views/ChatInput/ChatInputFormattingToolbar.jsis fixedFixes #1280
Video/Screenshots
N/A - code-only change
PR Test Details
Tooltips for formatters without keyboard shortcuts were showing a trailing space. The bug is in
packages/react/src/views/ChatInput/ChatInputFormattingToolbar.jsaround line 219. The template literal builds the label like:item.name ${item.shortcut &&(${item.shortcut})}. When there's no shortcut, that second part evaluates to an empty string. The space before it doesn't—so you end up with a dangling space in the tooltip.Changes made: