Repository navigation
Merge the Community section into Docs - #215
Open
ruben-arts wants to merge 1 commit into
Open
ruben-arts wants to merge 1 commit into
ruben-arts wants to merge 1 commit into
Conversation
New visitors had to guess whether Support, Contributing and the community meeting lived under Docs or under Community. The header now has Home, Docs and Packages, and the Docs sidebar groups the pages by what you came to do: use RoboStack, get help, contribute. The slugs are flat, so every URL stays the same. The sidebar groups don't collapse anymore and nested items indent half as far. Starlight has no setting for that, so SidebarList.astro renders the groups itself. src/routeData.ts goes too: it highlighted a "Packages" sidebar link that was removed in RoboStack#157.
Hofer-Julian
left a comment
Hofer-Julian
left a comment
Contributor
There was a problem hiding this comment.
Thanks, merging the pages makes sense to me.
I had one comment
Comment on lines
+4
to
+10
| /** | ||
| * The sidebar's link tree for the Sidebar override. Starlight's own | ||
| * SidebarSublist renders every group as a `<details>` toggle; here a group is | ||
| * a plain label over its links, so no section can be folded away. Badges and | ||
| * custom link attributes are not rendered: the sidebar config uses neither. | ||
| */ | ||
| interface Props { |
Contributor
There was a problem hiding this comment.
As far as I can see the purpose of this is to add another level of nesting to the sidebar. I don't think that is worth vendoring yet another starlight component
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New visitors had to guess whether Support, Contributing or the community meeting lived under Docs or under Community.
The header now has three tabs: Home, Docs and Packages.
The Community pages moved into the Docs sidebar, grouped by what you came to do:
No URL changes, so every existing link keeps working.
The pages already had flat slugs like
/support.html, they only move in the menu.The sidebar groups don't collapse anymore, and nested items indent half as far.
Starlight has no setting for that, so the new
SidebarList.astrorenders the groups as plain labels, with Starlight's own styles.Hiding the arrows with CSS wasn't enough: Starlight restores each group's open or closed state from session storage, so a group could stay folded.
Two leftovers from the old navigation are gone:
src/routeData.ts, which highlighted a "Packages" sidebar link that was removed in Add community meeting page and redesign the navigation #157Evidence
pixi run build-docsbuilds the same 19 HTML files as the currentgh-pagesbranch.pixi run lintpasses.Merge Danger
Door: two-way
Blast Radius: small
Only the header and the docs sidebar change.
Page content and URLs are untouched.
AI assisted by Claude Opus 5.5 (
claude-opus-5-5) in Claude Code.